Skip to content

[TASK]-[PYTHON-5623]: [v4.15] Change with_transaction callback return type to Awaitable #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2025
Merged

[TASK]-[PYTHON-5623]: [v4.15] Change with_transaction callback return type to Awaitable #2612

merged 4 commits into from
Nov 11, 2025
+53 −5

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Nov 11, 2025 •
edited
Loading

(cherry picked from commit 5f00966)

PYTHON-5623

Summary

Changes in this PR

Backport type signature and address docs failures and macos runner on GHA.

Testing Plan

Standard Tests

Screenshots (optional)

N/A

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is the intention of the code captured in relevant tests?
  • If there are new TODOs, has a related JIRA ticket been created?

Checklist for Reviewer {@primary_reviewer}

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Have you checked for spelling & grammar errors?
  • Is all relevant documentation (README or docstring) updated?

Focus Areas for Reviewer (optional)

@NoahStapp @lpulley @blink1073
[TASK]-[PYTHON-5623]: Change with_transaction callback return type to…
3a049e2 
… Awaitable (mongodb#2594)

Co-authored-by: Logan Pulley <logan@pulley.host>
(cherry picked from commit 5f00966)
@blink1073 blink1073 requested a review from a team as a code owner November 11, 2025 18:23
@blink1073 blink1073 changed the title [TASK]-[PYTHON-5623]: Change with_transaction callback return type to Awaitable [TASK]-[PYTHON-5623]: [v4.15] Change with_transaction callback return type to Awaitable Nov 11, 2025
aclark4life
aclark4life approved these changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@aclark4life aclark4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit 477217f into mongodb:v4.15 Nov 11, 2025
69 of 70 checks passed
@blink1073 blink1073 deleted the PYTHON-5623 branch November 11, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aclark4life aclark4life aclark4life approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blink1073 @aclark4life @NoahStapp