SWIFT-1347 Fix memory leak in tests caused by ClientSession.pinnedServerAddress (#675)

kmahar · web-flow · commit 53bc92d4624e · 2021-09-13T18:41:51.000-04:00
diff --git a/Sources/MongoSwift/ClientSession.swift b/Sources/MongoSwift/ClientSession.swift
@@ -94,8 +94,11 @@ public final class ClientSession {
             return nil
         }
         return connection.withMongocConnection { client in
-            let serverDescription =
-                ServerDescription(mongoc_client_get_server_description(client, serverID))
+            guard let sd = mongoc_client_get_server_description(client, serverID) else {
+                return nil
+            }
+            defer { mongoc_server_description_destroy(sd) }
+            let serverDescription = ServerDescription(sd)
             return serverDescription.address
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -94,8 +94,11 @@ public final class ClientSession {`
`94`	`94`	`return nil`
`95`	`95`	`}`
`96`	`96`	`return connection.withMongocConnection { client in`
`97`		`- let serverDescription =`
`98`		`- ServerDescription(mongoc_client_get_server_description(client, serverID))`
	`97`	`+ guard let sd = mongoc_client_get_server_description(client, serverID) else {`
	`98`	`+ return nil`
	`99`	`+ }`
	`100`	`+ defer { mongoc_server_description_destroy(sd) }`
	`101`	`+ let serverDescription = ServerDescription(sd)`
`99`	`102`	`return serverDescription.address`
`100`	`103`	`}`
`101`	`104`	`}`