fix notarizing code (#277)

* use correct go version, and use correct paths

* only trigger on git tags

Author: nammn

.evergreen.yml

@@ -1,5 +1,8 @@
 variables:
-
+  - &go_env
+    XDG_CONFIG_HOME: ${go_base_path}${workdir}
+    GO111MODULE: "on"
+    GOROOT: "/opt/golang/go1.21"
 functions:
 
   "clone":
@@ -42,24 +45,27 @@ functions:
       type: setup
       params:
         working_dir: src/github.com/mongodb/mongodb-enterprise-kubernetes/tools/multicluster
-        add_to_path:
-          - src/github.com/mongodb/tools
-          - src/github.com/mongodb/tools/linux_amd64
         include_expansions_in_env:
           - GITHUB_TOKEN
           - macos_notary_keyid
           - macos_notary_secret
           - workdir
+          - triggered_by_git_tag
         env:
+          <<: *go_env
           MACOS_NOTARY_KEY: ${macos_notary_keyid}
           MACOS_NOTARY_SECRET: ${macos_notary_secret}
+          GORELEASER_CURRENT_TAG: ${triggered_by_git_tag}
+        # shell.exec EVG Task doesn't have add_to_path, so we need to explicitly add the path export below.
         script: |
           set -Eeu pipefail
-          
-          ${workdir}/goreleaser release
+
+          export PATH=$GOROOT/bin:$PATH
+          ${workdir}/goreleaser release --rm-dist
 
 tasks:
   - name: package_goreleaser
+    git_tag_only: true
     tags: ["packaging"]
     commands:
       - func: "clone"

.github/workflows/release-multicluster-cli.yaml

@@ -20,7 +20,7 @@ set -Eeou pipefail
 # This depends on binaries being generated in a goreleaser manner and gon being set up.
 # goreleaser should already take care of calling this script as a hook.
 
-if [[ -f "./dist/kubectl-mongodb_darwin_arm64/kubectl-mongodb" && -f "./dist/kubectl-mongodb_darwin_amd64_v1/kubectl-mongodb" && ! -f "./dist/kubectl-mongodb_macos_signed.zip" ]]; then
+if [[ -f "./dist/kubectl-mongodb_darwin_amd64_v1/kubectl-mongodb" && -f "./dist/kubectl-mongodb_darwin_arm64/kubectl-mongodb" && ! -f "./dist/kubectl-mongodb_macos_signed.zip" ]]; then
 	echo "notarizing macOs binaries"
 	zip -r ./dist/kubectl-mongodb_amd64_arm64_bin.zip ./dist/kubectl-mongodb_darwin_amd64_v1/kubectl-mongodb ./dist/kubectl-mongodb_darwin_arm64/kubectl-mongodb # The Notarization Service takes an archive as input
 	"${workdir:-.}"/linux_amd64/macnotary \
@@ -30,6 +30,6 @@ if [[ -f "./dist/kubectl-mongodb_darwin_arm64/kubectl-mongodb" && -f "./dist/kub
 		-o ./dist/kubectl-mongodb_macos_signed.zip
 
 	echo "replacing original files"
-	unzip -oj ./dist/kubectl-mongodb_macos_signed.zip dist/macos_darwin_amd64_v1/kubectl-mongodb -d ./dist/macos_darwin_amd64_v1/
-	unzip -oj ./dist/kubectl-mongodb_macos_signed.zip dist/macos_darwin_arm64/kubectl-mongodb -d ./dist/macos_darwin_arm64/
+	unzip -oj ./dist/kubectl-mongodb_macos_signed.zip dist/kubectl-mongodb_darwin_amd64_v1/kubectl-mongodb -d ./dist/kubectl-mongodb_darwin_amd64_v1/
+	unzip -oj ./dist/kubectl-mongodb_macos_signed.zip dist/kubectl-mongodb_darwin_arm64/kubectl-mongodb -d ./dist/kubectl-mongodb_darwin_arm64/
 fi