Skip to content

ShaderMaterial: Fix copy method to include missing properties #32219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2025
Merged

ShaderMaterial: Fix copy method to include missing properties #32219

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1121a0a
ShaderMaterial: Fix copy method to include missing properties
NssGourav Nov 8, 2025
ec9bfee
Remove redundant property copies already handled by Material.copy()
NssGourav Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/materials/ShaderMaterial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ class ShaderMaterial extends Material {

this.wireframe = source.wireframe;
this.wireframeLinewidth = source.wireframeLinewidth;
this.linewidth = source.linewidth;

this.fog = source.fog;
this.lights = source.lights;
Expand All @@ -279,6 +280,14 @@ class ShaderMaterial extends Material {

this.glslVersion = source.glslVersion;

this.forceSinglePass = source.forceSinglePass;

this.defaultAttributeValues = Object.assign( {}, source.defaultAttributeValues );

this.index0AttributeName = source.index0AttributeName;

this.uniformsNeedUpdate = source.uniformsNeedUpdate;

return this;

}
Expand Down