-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Examples: Update webgpu_postprocessing_sss using pre-pass
#32345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
|
||
| const sssSample = sssPass.getTextureNode().sample( screenUV ).r; | ||
|
|
||
| const sssContext = context( { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future, do you think we could simplify this bit somehow? Maybe:
scenePass.contextNode = context( {
sss: sssPass.getTextureNode().sample( screenUV ).r
} );The instance of SSSNode has a reference to the directional main light so maybe you could hide some of this code in AnalyticLightNode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I still have to think of a way to simplify this utilization.
Related issue: #32295
Description
Add built-in support for
SSSusing pass context and update the example.SSS Pre-Pass
SSS No Pre-Pass