Make clearRecords an atomic replacement to reduce reactive updates.

Make clearRecords test more thorough.

Author: mrichar1

package.json

@@ -1,6 +1,6 @@
 {
   "name": "jsonapi-vuex",
-  "version": "5.11.1",
+  "version": "5.12.0",
   "description": "Access restructured JSONAPI data from a Vuex Store.",
   "author": "Matthew Richardson <M.Richardson@ed.ac.uk>",
   "scripts": {

src/mutations.js

@@ -5,7 +5,6 @@
  * @memberof module:jsonapi-vuex.jsonapiModule
  */
 
-import get from 'lodash/get'
 import { utils } from './jsonapi-vuex'
 
 export default () => {
@@ -59,21 +58,13 @@ export default () => {
       utils.updateRecords(state, records, true)
     },
     /**
-     * Delete all records from the store for a given type
+     * Delete all records from the store (of a given type) other than those included in a given record
      * @memberof module:jsonapi-vuex.jsonapiModule.mutations
      * @param {object} state - The Vuex state object
      * @param {object} records - A record with type set.
      */
     clearRecords: (state, records) => {
-      const newRecords = utils.normToStore(records)
-      for (let [type, item] of Object.entries(newRecords)) {
-        const storeRecords = get(state, [type], {})
-        for (let id of Object.keys(storeRecords)) {
-          if (!utils.hasProperty(item, id)) {
-            delete state[type][id]
-          }
-        }
-      }
+      Object.assign(state, utils.normToStore(records))
     },
   }
 }

tests/unit/jsonapi-vuex.spec.js

@@ -205,10 +205,12 @@ describe('jsonapi-vuex tests', function () {
     describe('clearRecords', function () {
       it('should remove records from the store not in the response (clearOnUpdate)', function () {
         const { clearRecords } = jm.mutations
-        const state = { widget: { 4: { foo: 4 } } }
+        const state = { widget: { 1: {}, 999: {} } }
         clearRecords(state, normRecord)
-        // '4' not in storeRecord, so should no longer be present in state
-        expect(state['widget']).to.not.have.property('4')
+        // '1' is in normRecord, so should still be present in state
+        expect(state['widget']).to.have.property('1')
+        // '999' not in normRecord, so should no longer be present in state
+        expect(state['widget']).to.not.have.property('999')
       })
     })
   }) // mutations