Fix: Preserve custom config fields when saving through UI #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add CUSTOM_ROUTER_PATH and NON_INTERACTIVE_MODE to Config interface - Add index signature to Config interface to allow custom fields - Modify ConfigProvider to preserve all original config fields - Only validate and set defaults for known fields - Fix type casting issues in App.tsx This ensures that custom fields like CUSTOM_ROUTER_PATH won't be lost when the config is saved through the UI interface.
sczheng189
force-pushed
the
fix/ui-config-custom-fields
branch
from
0c42c34 to
a09e10c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When custom fields like
CUSTOM_ROUTER_PATHare manually added to config.json, they get lost when the configuration is saved through the UI interface.Root Cause
The UI's ConfigProvider component uses a hardcoded list of fields and filters out any unknown fields when reading and saving the configuration.
Solution
CUSTOM_ROUTER_PATHandNON_INTERACTIVE_MODE) to the Config interfaceChanges
ui/src/types.ts: Added missing fields and index signatureui/src/components/ConfigProvider.tsx: Preserve all config fields using spread operatorui/src/App.tsxTesting
npm run buildThis ensures backward compatibility and allows users to add custom configuration fields without losing them when using the UI.