refactor(parser): improve browser rule variable naming

Author: BenjaminAbt

.vscode/tasks.json

@@ -1,16 +1,6 @@
 {
 	"version": "2.0.0",
 	"tasks": [
-		{
-			"label": "test",
-			"type": "shell",
-			"command": "dotnet test --nologo",
-			"args": [],
-			"problemMatcher": [
-				"$msCompile"
-			],
-			"group": "build"
-		},
 		{
 			"label": "test",
 			"type": "shell",
@@ -21,5 +11,3 @@
 			],
 			"group": "build"
 		}
-	]
-}

MyCSharp.HttpUserAgentParser.sln

@@ -27,6 +27,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "_", "_", "{5738CE0D-5E6E-47
 		Directory.Build.props = Directory.Build.props
 		Directory.Packages.props = Directory.Packages.props
 		global.json = global.json
+		Justfile = Justfile
 		LICENSE = LICENSE
 		NuGet.config = NuGet.config
 		README.md = README.md

src/HttpUserAgentParser/HttpUserAgentParser.cs

@@ -79,30 +79,30 @@ public static bool TryGetPlatform(string userAgent, [NotNullWhen(true)] out Http
     public static (string Name, string? Version)? GetBrowser(string userAgent)
     {
         ReadOnlySpan<char> ua = userAgent.AsSpan();
-    foreach ((string Name, string DetectToken, string? VersionToken) rule in HttpUserAgentStatics.s_browserRules)
+        foreach ((string Name, string DetectToken, string? VersionToken) browserRule in HttpUserAgentStatics.s_browserRules)
         {
-            if (!TryIndexOf(ua, rule.DetectToken, out int detectIndex))
+            if (!TryIndexOf(ua, browserRule.DetectToken, out int detectIndex))
             {
                 continue;
             }
 
             // Version token may differ (e.g., Safari uses "Version/")
             int versionSearchStart = detectIndex;
-            if (!string.IsNullOrEmpty(rule.VersionToken))
+            if (!string.IsNullOrEmpty(browserRule.VersionToken))
             {
-                if (TryIndexOf(ua, rule.VersionToken!, out int vtIndex))
+                if (TryIndexOf(ua, browserRule.VersionToken!, out int vtIndex))
                 {
-                    versionSearchStart = vtIndex + rule.VersionToken!.Length;
+                    versionSearchStart = vtIndex + browserRule.VersionToken!.Length;
                 }
                 else
                 {
                     // If specific version token wasn't found, fall back to detect token area
-                    versionSearchStart = detectIndex + rule.DetectToken.Length;
+                    versionSearchStart = detectIndex + browserRule.DetectToken.Length;
                 }
             }
             else
             {
-                versionSearchStart = detectIndex + rule.DetectToken.Length;
+                versionSearchStart = detectIndex + browserRule.DetectToken.Length;
             }
 
             string? version = null;
@@ -111,7 +111,7 @@ public static (string Name, string? Version)? GetBrowser(string userAgent)
                 version = userAgent.AsSpan(range.Start.Value, range.End.Value - range.Start.Value).ToString();
             }
 
-            return (rule.Name, version);
+            return (browserRule.Name, version);
         }
 
         return null;