Fix MySqlInfoMessageEventArgs API.

Remove property that was present just to be backwards compatible with Connector/NET.

Author: bgrainger

docs/content/api/MySqlConnector/MySqlInfoMessageEventArgs/Errors.md

@@ -0,0 +1,18 @@
+---
+title: Errors
+---
+
+# MySqlInfoMessageEventArgs.Errors property
+
+```csharp
+public IReadOnlyList<MySqlError> Errors { get; }
+```
+
+## See Also
+
+* class [MySqlError](../../MySqlErrorType/)
+* class [MySqlInfoMessageEventArgs](../../MySqlInfoMessageEventArgsType/)
+* namespace [MySqlConnector](../../MySqlInfoMessageEventArgsType/)
+* assembly [MySqlConnector](../../../MySqlConnectorAssembly/)
+
+<!-- DO NOT EDIT: generated by xmldocmd for MySqlConnector.dll -->

docs/content/api/MySqlConnector/MySqlInfoMessageEventArgsType.md

@@ -12,7 +12,6 @@ public sealed class MySqlInfoMessageEventArgs : EventArgs
 
 | name | description |
 | --- | --- |
-| [errors](../MySqlInfoMessageEventArgs/errors/) { get; } |  |
 | [Errors](../MySqlInfoMessageEventArgs/Errors/) { get; } |  |
 
 ## See Also

docs/content/tutorials/migrating-from-connector-net.md

@@ -135,6 +135,10 @@ removes most of the API that is based on those assumptions.
 To avoid ambiguity, there are two different factory methods for constructing a `MySqlGeometry`. Use the static factory method `MySqlGeometry.FromMySql` (if you have a byte array containing MySQL's internal format), or `FromWkb` if you have
 Well-known Binary bytes.
 
+### MySqlInfoMessageEventArgs
+
+The `MySqlError[] MySqlInfoMessageEventArgs.errors` property has changed to `IReadOnlyList<MySqlError> MySqlInfoMessageEventArgs.Errors`.
+
 ### Exceptions
 
 For consistency with other ADO.NET providers, MySqlConnector will throw `InvalidOperationException` (instead of `MySqlException`)

src/MySqlConnector/MySqlConnection.cs

@@ -759,7 +759,7 @@ internal void FinishQuerying(bool hasWarnings)
 						errors.Add(new(reader.GetString(0), reader.GetInt32(1), reader.GetString(2)));
 				}
 
-				InfoMessage(this, new MySqlInfoMessageEventArgs(errors.ToArray()));
+				InfoMessage(this, new MySqlInfoMessageEventArgs(errors));
 			}
 		}
 

src/MySqlConnector/MySqlInfoMessageEventArgs.cs

@@ -5,11 +5,9 @@ namespace MySqlConnector
 {
 	public sealed class MySqlInfoMessageEventArgs : EventArgs
 	{
-		internal MySqlInfoMessageEventArgs(MySqlError[] errors) => this.errors = errors;
+		internal MySqlInfoMessageEventArgs(IReadOnlyList<MySqlError> errors) => Errors = errors;
 
-		public MySqlError[] errors { get; }
-
-		public IReadOnlyList<MySqlError> Errors => errors;
+		public IReadOnlyList<MySqlError> Errors { get; }
 	}
 
 	public delegate void MySqlInfoMessageEventHandler(object sender, MySqlInfoMessageEventArgs args);

tests/SideBySide/ConnectionTests.cs

@@ -27,8 +27,13 @@ public void GotInfoMessageForNonExistentTable()
 			connection.InfoMessage += (s, a) =>
 			{
 				gotEvent = true;
+#if BASELINE
 				Assert.Single(a.errors);
 				Assert.Equal((int) MySqlErrorCode.BadTable, a.errors[0].Code);
+#else
+				Assert.Single(a.Errors);
+				Assert.Equal((int) MySqlErrorCode.BadTable, a.Errors[0].Code);
+#endif
 			};
 
 			connection.Execute(@"drop table if exists table_does_not_exist;");
@@ -46,8 +51,10 @@ public void NoInfoMessageWhenNotLastStatementInBatch()
 			{
 				gotEvent = true;
 
+#if BASELINE
 				// seeming bug in Connector/NET raises an event with no errors
 				Assert.Empty(a.errors);
+#endif
 			};
 
 			connection.Execute(@"drop table if exists table_does_not_exist; select 1;");