Reset state when opening is canceled. Fixes #1097

Author: bgrainger

src/MySqlConnector/MySqlConnection.cs

@@ -408,6 +408,11 @@ internal async Task OpenAsync(IOBehavior? ioBehavior, CancellationToken cancella
 				m_hasBeenOpened = true;
 				SetState(ConnectionState.Open);
 			}
+			catch (OperationCanceledException)
+			{
+				SetState(ConnectionState.Closed);
+				throw;
+			}
 			catch (MySqlException)
 			{
 				SetState(ConnectionState.Closed);

tests/SideBySide/ConnectAsync.cs

@@ -51,6 +51,22 @@ public async Task ConnectBadPassword()
 		Assert.Equal(ConnectionState.Closed, connection.State);
 	}
 
+	[Fact]
+	public async Task ConnectCanceled()
+	{
+		using var cts = new CancellationTokenSource();
+		cts.Cancel();
+
+		using var connection = new MySqlConnection(AppConfig.ConnectionString);
+#if BASELINE
+		await Assert.ThrowsAnyAsync<OperationCanceledException>(async () => await connection.OpenAsync(cts.Token));
+#else
+		await Assert.ThrowsAsync<OperationCanceledException>(async () => await connection.OpenAsync(cts.Token));
+#endif
+		await connection.OpenAsync();
+		Assert.Equal(ConnectionState.Open, connection.State);
+	}
+
 	[Fact]
 	public async Task State()
 	{