Call GC.SuppressFinalize for types derived from Component.

Component has a finalizer, but these derived types don't directly hold any unmanaged objects they need to clean up. Suppressing finalization improves performance (without impacting correctness) if the client doesn't Dispose these objects.

Author: bgrainger

src/MySqlConnector/MySql.Data.MySqlClient/MySqlCommand.cs

@@ -36,6 +36,7 @@ public MySqlCommand(string commandText, MySqlConnection connection)
 
 		public MySqlCommand(string commandText, MySqlConnection connection, MySqlTransaction transaction)
 		{
+			GC.SuppressFinalize(this);
 			CommandId = Interlocked.Increment(ref s_commandId);
 			CommandText = commandText;
 			Connection = connection;

src/MySqlConnector/MySql.Data.MySqlClient/MySqlCommandBuilder.cs

@@ -50,6 +50,7 @@ private static async Task DeriveParametersAsync(IOBehavior ioBehavior, MySqlComm
 #if !NETSTANDARD1_3
 		public MySqlCommandBuilder()
 		{
+			GC.SuppressFinalize(this);
 			QuotePrefix = "`";
 			QuoteSuffix = "`";
 		}

src/MySqlConnector/MySql.Data.MySqlClient/MySqlConnection.cs

@@ -21,7 +21,11 @@ public MySqlConnection()
 		{
 		}
 
-		public MySqlConnection(string connectionString) => ConnectionString = connectionString;
+		public MySqlConnection(string connectionString)
+		{
+			GC.SuppressFinalize(this);
+			ConnectionString = connectionString;
+		}
 
 		public new MySqlTransaction BeginTransaction() => (MySqlTransaction) base.BeginTransaction();
 		public new MySqlTransaction BeginTransaction(IsolationLevel isolationLevel) => (MySqlTransaction) base.BeginTransaction(isolationLevel);

src/MySqlConnector/MySql.Data.MySqlClient/MySqlDataAdapter.cs

@@ -1,4 +1,5 @@
 #if !NETSTANDARD1_3
+using System;
 using System.Data;
 using System.Data.Common;
 
@@ -8,9 +9,14 @@ public sealed class MySqlDataAdapter : DbDataAdapter
 	{
 		public MySqlDataAdapter()
 		{
+			GC.SuppressFinalize(this);
 		}
 
-		public MySqlDataAdapter(MySqlCommand selectCommand) => SelectCommand = selectCommand;
+		public MySqlDataAdapter(MySqlCommand selectCommand)
+			: this()
+		{
+			SelectCommand = selectCommand;
+		}
 
 		public MySqlDataAdapter(string selectCommandText, MySqlConnection connection)
 			: this(new MySqlCommand(selectCommandText, connection))