Enable all .NET analyzers.

Author: bgrainger

.editorconfig

@@ -67,6 +67,20 @@ csharp_space_between_method_call_parameter_list_parentheses = false
 csharp_space_between_parentheses = false
 csharp_preserve_single_line_blocks = true
 
+dotnet_diagnostic.CA1002.severity = none # Do not expose generic lists.
+dotnet_diagnostic.CA1003.severity = none # Use generic event handler instances.
+dotnet_diagnostic.CA1008.severity = none # Enums should have zero value.
+dotnet_diagnostic.CA1014.severity = none # Mark assemblies with CLSCompliantAttribute.
+dotnet_diagnostic.CA1031.severity = none # Do not catch general exception types.
+dotnet_diagnostic.CA1032.severity = none # Implement standard exception constructors.
+dotnet_diagnostic.CA1062.severity = silent # Validate arguments of public methods.
+dotnet_diagnostic.CA1307.severity = silent # Specify StringComparison for clarity.
+dotnet_diagnostic.CA1508.severity = silent # Avoid dead conditional code.
+dotnet_diagnostic.CA1849.severity = none # Call async methods when in an async method.
+dotnet_diagnostic.CA2000.severity = none # Use recommended Dispose pattern.
+dotnet_diagnostic.CA2100.severity = none # Review SQL queries for security vulnerabilities.
+dotnet_diagnostic.CA2213.severity = silent # Disposable fields should be disposed.
+dotnet_diagnostic.CA5398.severity = none # Avoid hardcoded SslProtocols values.
 dotnet_diagnostic.SA1003.severity = none # Operator must not be followed by whitespace.
 dotnet_diagnostic.SA1008.severity = none # Opening parenthesis must not be preceded by a space.
 dotnet_diagnostic.SA1009.severity = none # Closing parenthesis must not be followed by a space.

src/Directory.Build.props

@@ -14,7 +14,7 @@
     <RepositoryUrl>https://github.com/mysql-net/MySqlConnector.git</RepositoryUrl>
     <DebugType>embedded</DebugType>
     <LangVersion>preview</LangVersion>
-    <AnalysisLevel>latest-recommended</AnalysisLevel>
+    <AnalysisLevel>latest-all</AnalysisLevel>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>

src/MySqlConnector/Core/ConnectionSettings.cs

@@ -84,7 +84,7 @@ public ConnectionSettings(MySqlConnectionStringBuilder csb)
 				throw new NotSupportedException("All specified TLS versions are incompatible with this platform.");
 		}
 
-		if (csb.TlsCipherSuites != "")
+		if (csb.TlsCipherSuites.Length != 0)
 		{
 #if NETCOREAPP3_0_OR_GREATER
 			var tlsCipherSuites = new List<TlsCipherSuite>();

src/MySqlConnector/Core/ILoadBalancer.cs

@@ -26,6 +26,7 @@ internal sealed class RandomLoadBalancer : ILoadBalancer
 
 	public IEnumerable<string> LoadBalance(IReadOnlyList<string> hosts)
 	{
+#pragma warning disable CA5394 // Do not use insecure randomness
 		// from https://en.wikipedia.org/wiki/Fisher%E2%80%93Yates_shuffle#The_modern_algorithm
 		var shuffled = new List<string>(hosts);
 		for (var i = hosts.Count - 1; i >= 1; i--)

src/MySqlConnector/Core/NormalizedSchema.cs

@@ -6,7 +6,7 @@ internal sealed class NormalizedSchema
 {
 	private const string ReQuoted = @"`((?:[^`]|``)+)`";
 	private const string ReUnQuoted = @"([^\.`]+)";
-	private static readonly string ReEither = $@"(?:{ReQuoted}|{ReUnQuoted})";
+	private const string ReEither = $@"(?:{ReQuoted}|{ReUnQuoted})";
 
 	private static readonly Regex NameRe = new(
 		$@"^\s*{ReEither}\s*(?:\.\s*{ReEither}\s*)?$",

src/MySqlConnector/Logging/MySqlConnectorLogManager.cs

@@ -9,6 +9,7 @@ public static class MySqlConnectorLogManager
 	/// Allows the <see cref="IMySqlConnectorLoggerProvider"/> to be set for this library. <see cref="Provider"/> can
 	/// be set once, and must be set before any other library methods are used.
 	/// </summary>
+#pragma warning disable CA1044 // Properties should not be write only
 	public static IMySqlConnectorLoggerProvider Provider
 	{
 		internal get

src/MySqlConnector/MySqlBatch.cs

@@ -49,6 +49,9 @@ namespace MySqlConnector;
 /// </code>
 /// </summary>
 /// <remarks>The proposed ADO.NET API that <see cref="MySqlBatch"/> is based on is not finalized. This API is experimental and may change in the future.</remarks>
+#if NET6_0_OR_GREATER
+#pragma warning disable CA1063 // Implement IDisposable Correctly
+#endif
 public sealed class MySqlBatch :
 #if NET6_0_OR_GREATER
 	DbBatch,
@@ -120,7 +123,7 @@ public MySqlDataReader ExecuteReader(CommandBehavior commandBehavior = CommandBe
 #else
 	public async Task<MySqlDataReader> ExecuteReaderAsync(CancellationToken cancellationToken = default) =>
 #endif
-		(MySqlDataReader) await ExecuteDbDataReaderAsync(CommandBehavior.Default, cancellationToken);
+		(MySqlDataReader) await ExecuteDbDataReaderAsync(CommandBehavior.Default, cancellationToken).ConfigureAwait(false);
 
 	//// TODO: new ExecuteReaderAsync(CommandBehavior)
 
@@ -340,7 +343,7 @@ private bool NeedsPrepare(out Exception? exception)
 			exception = new InvalidOperationException("Connection must be Open; current state is {0}".FormatInvariant(Connection.State));
 		else if (BatchCommands.Count == 0)
 			exception = new InvalidOperationException("BatchCommands must contain a command");
-		else if (Connection?.HasActiveReader ?? false)
+		else if (Connection.HasActiveReader)
 			exception = new InvalidOperationException("Cannot call Prepare when there is an open DataReader for this command; it must be closed first.");
 		else
 			exception = GetExceptionForInvalidCommands();

src/MySqlConnector/MySqlCommand.cs

@@ -446,8 +446,6 @@ private bool IsValid([NotNullWhen(false)] out Exception? exception)
 	MySqlParameterCollection? IMySqlCommand.OutParameters { get; set; }
 	MySqlParameter? IMySqlCommand.ReturnParameter { get; set; }
 
-	private static readonly IMySqlConnectorLogger Log = MySqlConnectorLogManager.CreateLogger(nameof(MySqlCommand));
-
 	private readonly int m_commandId;
 	private bool m_isDisposed;
 	private MySqlConnection? m_connection;

src/MySqlConnector/MySqlConnectionProtocol.cs

@@ -1,5 +1,6 @@
 namespace MySqlConnector;
 
+#pragma warning disable CA1027 // Mark enums with FlagsAttribute
 #pragma warning disable CA1069 // Enum values should not be duplicated
 /// <summary>
 /// Specifies the type of connection to make to the server.

src/MySqlConnector/MySqlConnectionStringBuilder.cs

@@ -962,6 +962,8 @@ private static void AddOption(MySqlConnectionStringOption option)
 			s_options.Add(key, option);
 	}
 
+#pragma warning disable CA1065 // Do not raise exceptions in unexpected locations
+#pragma warning disable CA1810 // Initialize reference type static fields inline
 	static MySqlConnectionStringOption()
 	{
 		s_options = new(StringComparer.OrdinalIgnoreCase);