Support NEWDATE column type. Fixes #1007

Author: bgrainger

src/MySqlConnector/Core/BinaryRow.cs

@@ -49,8 +49,8 @@ protected override void GetDataOffsets(ReadOnlySpan<byte> data, int[] dataOffset
 						ColumnType.Long or ColumnType.Int24 or ColumnType.Float => 4,
 						ColumnType.Short or ColumnType.Year => 2,
 						ColumnType.Tiny => 1,
-						ColumnType.Date or ColumnType.DateTime or ColumnType.Timestamp or ColumnType.Time => reader.ReadByte(),
-						ColumnType.DateTime2 or ColumnType.NewDate or ColumnType.Timestamp2 => throw new NotSupportedException("ColumnType {0} is not supported".FormatInvariant(columnDefinition.ColumnType)),
+						ColumnType.Date or ColumnType.DateTime or ColumnType.NewDate or ColumnType.Timestamp or ColumnType.Time => reader.ReadByte(),
+						ColumnType.DateTime2 or ColumnType.Timestamp2 => throw new NotSupportedException("ColumnType {0} is not supported".FormatInvariant(columnDefinition.ColumnType)),
 						_ => checked((int) reader.ReadLengthEncodedInteger()),
 					};
 
@@ -130,6 +130,7 @@ protected override object GetValueCore(ReadOnlySpan<byte> data, ColumnDefinition
 
 			case ColumnType.Date:
 			case ColumnType.DateTime:
+			case ColumnType.NewDate:
 			case ColumnType.Timestamp:
 				return ReadDateTime(data);
 

src/MySqlConnector/Core/TextRow.cs

@@ -86,6 +86,7 @@ protected override object GetValueCore(ReadOnlySpan<byte> data, ColumnDefinition
 
 			case ColumnType.Date:
 			case ColumnType.DateTime:
+			case ColumnType.NewDate:
 			case ColumnType.Timestamp:
 				return ParseDateTime(data);
 

src/MySqlConnector/Core/TypeMapper.cs

@@ -250,6 +250,7 @@ public static MySqlDbType ConvertToMySqlDbType(ColumnDefinitionPayload columnDef
 				return isUnsigned ? MySqlDbType.UInt16 : MySqlDbType.Int16;
 
 			case ColumnType.Date:
+			case ColumnType.NewDate:
 				return MySqlDbType.Date;
 
 			case ColumnType.DateTime:

tests/SideBySide/DataTypes.cs

@@ -953,6 +953,37 @@ public void GetMySqlDateTime(string columnName)
 			}
 		}
 
+		[Theory]
+		[InlineData(false)]
+		[InlineData(true)]
+		public void ReadNewDate(bool prepare)
+		{
+			// returns a NEWDATE in MySQL < 5.7.22; see https://github.com/mysql-net/MySqlConnector/issues/1007
+			using var cmd = new MySqlCommand($"SELECT `Date` FROM datatypes_times UNION ALL SELECT `Date` FROM datatypes_times", Connection);
+			if (prepare)
+				cmd.Prepare();
+			using var reader = cmd.ExecuteReader();
+
+#if !BASELINE
+			var columnSchema = reader.GetColumnSchema()[0];
+			Assert.Equal("Date", columnSchema.ColumnName);
+			Assert.Equal(typeof(DateTime), columnSchema.DataType);
+			Assert.Equal("DATE", columnSchema.DataTypeName);
+#endif
+
+#if !NETCOREAPP1_1_2
+			var schemaRow = reader.GetSchemaTable().Rows[0];
+			Assert.Equal("Date", schemaRow["ColumnName"]);
+			Assert.Equal(typeof(DateTime), schemaRow["DataType"]);
+#endif
+
+			while (reader.Read())
+			{
+				if (!reader.IsDBNull(0))
+					reader.GetDateTime(0);
+			}
+		}
+
 		[Theory]
 		[InlineData("Geometry", "GEOMETRY", new byte[] { 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 240, 63, 0, 0, 0, 0, 0, 0, 240, 63 })]
 		[InlineData("Point", "GEOMETRY", new byte[] { 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 240, 63, 0, 0, 0, 0, 0, 0, 240, 63 })]