Merge pull request #1000 from kpreisser/noBackslashEscapesWithBinary

Support NoBackslashEscapes for binary parameter values.

Author: bgrainger

src/MySqlConnector/MySqlParameter.cs

@@ -305,7 +305,7 @@ internal void AppendSqlString(ByteBufferWriter writer, StatementPreparerOptions
 				var length = inputSpan.Length + BinaryBytes.Length + 1;
 				foreach (var by in inputSpan)
 				{
-					if (by is 0x27 or 0x5C)
+					if (by is 0x27 || by is 0x5C && !noBackslashEscapes)
 						length++;
 				}
 
@@ -314,8 +314,8 @@ internal void AppendSqlString(ByteBufferWriter writer, StatementPreparerOptions
 				var index = BinaryBytes.Length;
 				foreach (var by in inputSpan)
 				{
-					if (by is 0x27 or 0x5C)
-						outputSpan[index++] = 0x5C;
+					if (by is 0x27 || by is 0x5C && !noBackslashEscapes)
+						outputSpan[index++] = by;
 					outputSpan[index++] = by;
 				}
 				outputSpan[index++] = 0x27;

tests/MySqlConnector.Tests/StatementPreparerTests.cs

@@ -175,9 +175,12 @@ public void FormatParameter(object parameterValue, string replacedValue, bool no
 				new object[] { new TimeSpan(2, 3, 4, 5, 6), "time '51:04:05.006000'" },
 				new object[] { new TimeSpan(-2, -3, -4, -5, -6), "time '-51:04:05.006000'" },
 				new object[] { new Guid("00112233-4455-6677-8899-AABBCCDDEEFF"), "'00112233-4455-6677-8899-aabbccddeeff'" },
-				new object[] { new byte[] { 0x41, 0x42, 0x27, 0x61 }, "_binary'AB\\'a'" },
-				new object[] { new MemoryStream(new byte[] { 0x41, 0x42, 0x27, 0x61 }), "_binary'AB\\'a'" },
-				new object[] { new MemoryStream(new byte[] { 0, 0x41, 0x42, 0x27, 0x61, 0x62 }, 1, 4, false, true), "_binary'AB\\'a'" },
+				new object[] { new byte[] { 0x41, 0x42, 0x27, 0x61, 0x5c, 0x62 }, @"_binary'AB''a\\b'" },
+				new object[] { new byte[] { 0x41, 0x42, 0x27, 0x61, 0x5c, 0x62 }, @"_binary'AB''a\b'", true },
+				new object[] { new MemoryStream(new byte[] { 0x41, 0x42, 0x27, 0x61, 0x5c, 0x62 }), @"_binary'AB''a\\b'" },
+				new object[] { new MemoryStream(new byte[] { 0x41, 0x42, 0x27, 0x61, 0x5c, 0x62 }), @"_binary'AB''a\b'", true },
+				new object[] { new MemoryStream(new byte[] { 0, 0x41, 0x42, 0x27, 0x61, 0x5c, 0x62, 0x63 }, 1, 6, false, true), @"_binary'AB''a\\b'" },
+				new object[] { new MemoryStream(new byte[] { 0, 0x41, 0x42, 0x27, 0x61, 0x5c, 0x62, 0x63 }, 1, 6, false, true), @"_binary'AB''a\b'", true },
 				new object[] { "\"AB\\ab'".AsMemory(), @"'""AB\\ab'''" },
 				new object[] { new StringBuilder("\"AB\\ab'"), @"'""AB\\ab'''" },
 			};