Change logging from Info to Debug. Fixes #956

The new background connection reset code in 1.3.0 caused two new "Info" log messages for each connection retrieved from the pool.

The ping message would have been logged when ConnectionReset=false, but that was not the default behaviour.

Author: bgrainger

src/MySqlConnector/Core/BackgroundConnectionResetHelper.cs

@@ -77,7 +77,7 @@ public static async Task ReturnSessionsAsync()
 				try
 				{
 					// block until AddSession releases the semaphore
-					Log.Info("Waiting for semaphore.");
+					Log.Debug("Waiting for semaphore.");
 					await s_semaphore.WaitAsync(s_cancellationTokenSource.Token).ConfigureAwait(false);
 
 					// process all sessions that have started being returned

src/MySqlConnector/Core/ConnectionPool.cs

@@ -72,7 +72,7 @@ public async ValueTask<ServerSession> GetSessionAsync(MySqlConnection connection
 						}
 						else if ((unchecked((uint) Environment.TickCount) - session.LastReturnedTicks) >= ConnectionSettings.ConnectionIdlePingTime)
 						{
-							reuseSession = await session.TryPingAsync(ioBehavior, cancellationToken).ConfigureAwait(false);
+							reuseSession = await session.TryPingAsync(logInfo: false, ioBehavior, cancellationToken).ConfigureAwait(false);
 						}
 						else
 						{

src/MySqlConnector/Core/ServerSession.cs

@@ -745,7 +745,7 @@ private async Task<string> GetRsaPublicKeyAsync(string switchRequestName, Connec
 		}
 #endif
 
-		public async ValueTask<bool> TryPingAsync(IOBehavior ioBehavior, CancellationToken cancellationToken)
+		public async ValueTask<bool> TryPingAsync(bool logInfo, IOBehavior ioBehavior, CancellationToken cancellationToken)
 		{
 			VerifyState(State.Connected);
 
@@ -756,7 +756,10 @@ public async ValueTask<bool> TryPingAsync(IOBehavior ioBehavior, CancellationTok
 				await SendAsync(PingPayload.Instance, ioBehavior, cancellationToken).ConfigureAwait(false);
 				var payload = await ReceiveReplyAsync(ioBehavior, cancellationToken).ConfigureAwait(false);
 				OkPayload.Create(payload.Span, SupportsDeprecateEof, SupportsSessionTrack);
-				Log.Info("Session{0} successfully pinged server", m_logArguments);
+				if (logInfo)
+					Log.Info("Session{0} successfully pinged server", m_logArguments);
+				else
+					Log.Debug("Session{0} successfully pinged server", m_logArguments);
 				return true;
 			}
 			catch (IOException ex)

src/MySqlConnector/MySqlConnection.cs

@@ -366,7 +366,7 @@ private async ValueTask<bool> PingAsync(IOBehavior ioBehavior, CancellationToken
 				return false;
 			try
 			{
-				if (await m_session.TryPingAsync(ioBehavior, cancellationToken).ConfigureAwait(false))
+				if (await m_session.TryPingAsync(logInfo: true, ioBehavior, cancellationToken).ConfigureAwait(false))
 					return true;
 			}
 			catch (InvalidOperationException)