Fix NativeGetFiles to hidde sys and hidden files (#2997)

Author: josesimoes

src/System.IO.FileSystem/nf_sys_io_filesystem_System_IO_Directory.cpp

@@ -56,16 +56,37 @@ HRESULT Library_nf_sys_io_filesystem_System_IO_Directory::NativeGetChildren___ST
         // do nothing here, just iterate to count the items
         if (found)
         {
-            if (isDirectory && ((fileData.Attributes & FileAttributes::FileAttributes_Directory) ==
-                                FileAttributes::FileAttributes_Directory))
+            // skip entries that are not directories when looking for directories
+            // skip also directories with hidden and system attribute
+            if (isDirectory &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_Directory) ==
+                 FileAttributes::FileAttributes_Directory) &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_Hidden) !=
+                 FileAttributes::FileAttributes_Hidden) &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_System) !=
+                 FileAttributes::FileAttributes_System))
             {
                 itemsCount++;
             }
+            // skip entries that are directories when looking for files
+            // skip also files with hidden and system attribute along with extension 'sys'
             else if (
-                !isDirectory && ((fileData.Attributes & FileAttributes::FileAttributes_Directory) !=
-                                 FileAttributes::FileAttributes_Directory))
+                !isDirectory &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_Directory) !=
+                 FileAttributes::FileAttributes_Directory) &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_Hidden) !=
+                 FileAttributes::FileAttributes_Hidden) &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_System) !=
+                 FileAttributes::FileAttributes_System))
             {
-                itemsCount++;
+                const char *fileName = (const char *)fileData.FileName;
+                const char *extension = strrchr(fileName, '.');
+
+                if (extension == NULL || strcmp(extension, ".sys") != 0)
+                {
+                    // file does not have a .sys extension, OK to add to list
+                    itemsCount++;
+                }
             }
         }
 
@@ -99,16 +120,36 @@ HRESULT Library_nf_sys_io_filesystem_System_IO_Directory::NativeGetChildren___ST
         // do nothing here, just iterate to count the items
         if (found)
         {
-            if (isDirectory && ((fileData.Attributes & FileAttributes::FileAttributes_Directory) !=
-                                FileAttributes::FileAttributes_Directory))
+            // skip entries that are not directories when looking for directories
+            // skip also directories with hidden and system attribute
+            if (isDirectory &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_Directory) !=
+                 FileAttributes::FileAttributes_Directory) &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_Hidden) !=
+                 FileAttributes::FileAttributes_Hidden) &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_System) !=
+                 FileAttributes::FileAttributes_System))
             {
                 continue;
             }
+            // skip entries that are directories when looking for files
+            // skip also files with hidden and system attribute along with extension 'sys'
             else if (
-                !isDirectory && ((fileData.Attributes & FileAttributes::FileAttributes_Directory) ==
-                                 FileAttributes::FileAttributes_Directory))
+                !isDirectory &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_Directory) ==
+                 FileAttributes::FileAttributes_Directory) &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_Hidden) ==
+                 FileAttributes::FileAttributes_Hidden) &&
+                ((fileData.Attributes & FileAttributes::FileAttributes_System) ==
+                 FileAttributes::FileAttributes_System))
             {
-                continue;
+                const char *fileName = (const char *)fileData.FileName;
+                const char *extension = strrchr(fileName, '.');
+                if (extension != NULL && strcmp(extension, ".sys") == 0)
+                {
+                    // file has a .sys extension, skip it
+                    continue;
+                }
             }
 
             // compose file path