Proper handling thread creation failure (#3063)

josesimoes · web-flow · commit 3fd2ac0a22fd · 2025-01-09T15:17:01.000Z
diff --git a/targets/AzureRTOS/ST/_nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp b/targets/AzureRTOS/ST/_nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp
@@ -580,7 +580,11 @@ HRESULT Library_sys_dev_i2c_native_System_Device_I2c_I2cDevice::
 
             if (status != TX_SUCCESS)
             {
-                NANOCLR_SET_AND_LEAVE(CLR_E_PROCESS_EXCEPTION);
+                // failed to create the thread
+                // free stack memory
+                platform_free(palI2c->WorkingThreadStack);
+
+                NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);
             }
 
             // bump custom state
diff --git a/targets/AzureRTOS/SiliconLabs/_nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp b/targets/AzureRTOS/SiliconLabs/_nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp
@@ -583,7 +583,11 @@ HRESULT Library_sys_dev_i2c_native_System_Device_I2c_I2cDevice::
 
             if (status != TX_SUCCESS)
             {
-                NANOCLR_SET_AND_LEAVE(CLR_E_PROCESS_EXCEPTION);
+                // failed to create the thread
+                // free stack memory
+                platform_free(palI2c->WorkingThreadStack);
+
+                NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);
             }
 
             // bump custom state
diff --git a/targets/AzureRTOS/SiliconLabs/_nanoCLR/nanoFramework.Device.OneWire/nf_dev_onewire_nanoFramework_Device_OneWire_OneWireHost.cpp b/targets/AzureRTOS/SiliconLabs/_nanoCLR/nanoFramework.Device.OneWire/nf_dev_onewire_nanoFramework_Device_OneWire_OneWireHost.cpp
@@ -471,7 +471,11 @@ HRESULT FindOneDevice(CLR_RT_StackFrame &stack, bool findFirst)
 
         if (status != TX_SUCCESS)
         {
-            NANOCLR_SET_AND_LEAVE(CLR_E_PROCESS_EXCEPTION);
+            // failed to create the thread
+            // free stack memory
+            platform_free(workingThreadStack);
+
+            NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);
         }
 
         // bump custom state

Original file line number	Diff line number	Diff line change
`@@ -580,7 +580,11 @@ HRESULT Library_sys_dev_i2c_native_System_Device_I2c_I2cDevice::`
`580`	`580`
`581`	`581`	`if (status != TX_SUCCESS)`
`582`	`582`	`{`
`583`		`- NANOCLR_SET_AND_LEAVE(CLR_E_PROCESS_EXCEPTION);`
	`583`	`+ // failed to create the thread`
	`584`	`+ // free stack memory`
	`585`	`+ platform_free(palI2c->WorkingThreadStack);`
	`586`	`+`
	`587`	`+ NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);`
`584`	`588`	`}`
`585`	`589`
`586`	`590`	`// bump custom state`
Original file line number	Diff line number	Diff line change
`@@ -583,7 +583,11 @@ HRESULT Library_sys_dev_i2c_native_System_Device_I2c_I2cDevice::`
`583`	`583`
`584`	`584`	`if (status != TX_SUCCESS)`
`585`	`585`	`{`
`586`		`- NANOCLR_SET_AND_LEAVE(CLR_E_PROCESS_EXCEPTION);`
	`586`	`+ // failed to create the thread`
	`587`	`+ // free stack memory`
	`588`	`+ platform_free(palI2c->WorkingThreadStack);`
	`589`	`+`
	`590`	`+ NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);`
`587`	`591`	`}`
`588`	`592`
`589`	`593`	`// bump custom state`
Original file line number	Diff line number	Diff line change
`@@ -471,7 +471,11 @@ HRESULT FindOneDevice(CLR_RT_StackFrame &stack, bool findFirst)`
`471`	`471`
`472`	`472`	`if (status != TX_SUCCESS)`
`473`	`473`	`{`
`474`		`- NANOCLR_SET_AND_LEAVE(CLR_E_PROCESS_EXCEPTION);`
	`474`	`+ // failed to create the thread`
	`475`	`+ // free stack memory`
	`476`	`+ platform_free(workingThreadStack);`
	`477`	`+`
	`478`	`+ NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);`
`475`	`479`	`}`
`476`	`480`
`477`	`481`	`// bump custom state`