Fix parameter bug and enhance documentation for WithTlsNegotiator method #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a parameter bug and enhances documentation for the WithTlsNegotiator method while also improving the ToDictionary functionality and adding comprehensive tests.
- Update XML docs for WithTlsNegotiator to warn users about certificate validation when overriding the default TLS negotiator.
- Introduce a TryGetDictionaryOfStringKeys extension method along with a read-only dictionary wrapper to avoid allocations.
- Add tests for parameter setting and dictionary conversion use cases.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Neo4j.Driver/Public/ConfigBuilder.cs | Updated method documentation for WithTlsNegotiator to clarify TLS certificate validation responsibilities. |
| Neo4j.Driver/Internal/Extensions/CollectionExtensions.cs | Added TryGetDictionaryOfStringKeys logic and a read-only dictionary wrapper to support IDictionary of string keys. |
| Neo4j.Driver.Tests/TestUtil/CollectionExtensionsTests.cs | Introduced tests covering various scenarios for the ToDictionary extension method. |
| Neo4j.Driver.Tests/ExecutableQuery/ExecutableQueryTests.cs | Added tests to verify parameter handling using both anonymous objects and dictionaries. |
Neo4j.Driver/Neo4j.Driver/Internal/Extensions/CollectionExtensions.cs
Outdated
Show resolved
Hide resolved
…ions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added specific tests for the case that caused the bug. Fixed using a struct wrapper for the dictionary that won't cause any allocations. Also a little docs update for specifying your own ITlsNegotiator.