-
Notifications
You must be signed in to change notification settings - Fork 448
Modules: adding test dataset for testing the hificnv module #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e43c119
Add test datasets for hificnv module testing
chaochaowong 7219335
edit README.md to add description of test datasets added for hificnv
chaochaowong 6d8278f
added pacbio/vcf file for the hificnv module testing
chaochaowong 1a3c2a6
edited READE.md for the description of the vcf file made for the hifi…
chaochaowong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
508,186 changes: 508,186 additions & 0 deletions
508,186
data/genomics/homo_sapiens/genome/GRCh38_chr22.fasta
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| chr22 50818468 7 100 101 |
Binary file added
BIN
+23.3 MB
...cs/homo_sapiens/pacbio/bam/SCRI_KT5028_GRCh38_downsampled_on_chr22_pbmm2_snv_hiphased.bam
Binary file not shown.
Binary file added
BIN
+4.41 KB
...omo_sapiens/pacbio/bam/SCRI_KT5028_GRCh38_downsampled_on_chr22_pbmm2_snv_hiphased.bam.csi
Binary file not shown.
Binary file added
BIN
+2.05 MB
...homo_sapiens/pacbio/vcf/SCRI_KT5028_GRCh38_downsampled_on_chr22_pbmm2_snv_hiphased.vcf.gz
Binary file not shown.
Binary file added
BIN
+20.4 KB
..._sapiens/pacbio/vcf/SCRI_KT5028_GRCh38_downsampled_on_chr22_pbmm2_snv_hiphased.vcf.gz.tbi
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice descriptions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for reviewing it. I really appreciate it.
The aligned-phased BAM and MAF VCF files span the entire chr22, so the FASTA file also covers the whole chromosome and is indeed large, as you mentioned. I might try using
homo_sapiens/genome/genome.fasta(chr22:16,570,000–16,610,000) to limit reads in the region, but I’m not sure if it’s based on GRCh38. Do you know? I’ll continue working on it this weekend. Thanks again.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so based on what I see: https://github.com/nf-core/test-datasets/blob/modules/data/genomics/homo_sapiens/README.md#reference-files
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inemesb Thanks for reviewing! I found that the genomics/homo_sapiens/pacbio directory includes suitable genome3.fasta, BAM, and VCF files for the
hificnvmodule I submitted. I wasn’t very familiar with nf-core’s test datasets before, but I’m getting the hang of it now. Since thehificnvno longer needs the test datasets I made, I will close this PR. Thank you again for your help.