Ignore tests failing due to broken type inference for selected parameters

Author: fredericDelaporte

src/NHibernate.Test/Async/Criteria/CriteriaQueryTest.cs

@@ -2719,6 +2719,9 @@ public async Task OrderProjectionTestAsync()
 		[Test]
 		public async Task OrderProjectionAliasedTestAsync()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (ISession session = OpenSession())
 			using (ITransaction t = session.BeginTransaction())
 			{

src/NHibernate.Test/Async/Criteria/Lambda/FunctionsIntegrationFixture.cs

@@ -146,6 +146,9 @@ public async Task FunctionsToLowerToUpperAsync()
 		[Test]
 		public async Task ConcatAsync()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (var s = OpenSession())
 			using (s.BeginTransaction())
 			{

src/NHibernate.Test/Async/Criteria/ProjectionsTest.cs

@@ -69,6 +69,9 @@ protected override void OnTearDown()
 		[Test]
 		public async Task UsingSqlFunctions_ConcatAsync()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (ISession session = Sfi.OpenSession())
 			{
 				string result = await (session.CreateCriteria(typeof(Student))
@@ -90,6 +93,9 @@ public async Task UsingSqlFunctions_Concat_WithCastAsync()
 			{
 				Assert.Ignore("Not supported by the active dialect:{0}.", Dialect);
 			}
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (ISession session = Sfi.OpenSession())
 			{
 				string result = await (session.CreateCriteria(typeof(Student))
@@ -176,6 +182,9 @@ public async Task CanUseParametersWithProjectionsAsync()
 		[Test]
 		public async Task UsingConditionalsAsync()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (ISession session = Sfi.OpenSession())
 			{
 				string result = await (session.CreateCriteria(typeof(Student))

src/NHibernate.Test/Async/NHSpecificTest/NH1280/NH1280Fixture.cs

@@ -52,6 +52,9 @@ protected override void OnTearDown()
 		[Test]
 		public async Task HavingUsingSqlFunctions_ConcatAsync()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (ISession s = OpenSession())
 			using (ITransaction tx = s.BeginTransaction())
 			{
@@ -272,4 +275,4 @@ public async Task HavingOnNotExpressionCountAsync()
 			}
 		}
 	}
-}
+}

src/NHibernate.Test/Async/TypesTest/DecimalTypeFixture.cs

@@ -95,6 +95,9 @@ public async Task ReadWriteAsync()
 		[Test]
 		public async Task HighScaleParameterSelectAsync()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (var s = OpenSession())
 			using (var t = s.BeginTransaction())
 			{

src/NHibernate.Test/Criteria/CriteriaQueryTest.cs

@@ -2734,6 +2734,9 @@ public void OrderProjectionTest()
 		[Test]
 		public void OrderProjectionAliasedTest()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (ISession session = OpenSession())
 			using (ITransaction t = session.BeginTransaction())
 			{

src/NHibernate.Test/Criteria/Lambda/FunctionsIntegrationFixture.cs

@@ -135,6 +135,9 @@ public void FunctionsToLowerToUpper()
 		[Test]
 		public void Concat()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (var s = OpenSession())
 			using (s.BeginTransaction())
 			{

src/NHibernate.Test/Criteria/ProjectionsTest.cs

@@ -58,6 +58,9 @@ protected override void OnTearDown()
 		[Test]
 		public void UsingSqlFunctions_Concat()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (ISession session = Sfi.OpenSession())
 			{
 				string result = session.CreateCriteria(typeof(Student))
@@ -79,6 +82,9 @@ public void UsingSqlFunctions_Concat_WithCast()
 			{
 				Assert.Ignore("Not supported by the active dialect:{0}.", Dialect);
 			}
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (ISession session = Sfi.OpenSession())
 			{
 				string result = session.CreateCriteria(typeof(Student))
@@ -165,6 +171,9 @@ public void CanUseParametersWithProjections()
 		[Test]
 		public void UsingConditionals()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (ISession session = Sfi.OpenSession())
 			{
 				string result = session.CreateCriteria(typeof(Student))

src/NHibernate.Test/NHSpecificTest/NH1280/NH1280Fixture.cs

@@ -41,6 +41,9 @@ protected override void OnTearDown()
 		[Test]
 		public void HavingUsingSqlFunctions_Concat()
 		{
+			if (TestDialect.HasBrokenTypeInferenceOnSelectedParameters)
+				Assert.Ignore("Current dialect does not support this test");
+
 			using (ISession s = OpenSession())
 			using (ITransaction tx = s.BeginTransaction())
 			{
@@ -261,4 +264,4 @@ public void HavingOnNotExpressionCount()
 			}
 		}
 	}
-}
+}

src/NHibernate.Test/TestDialect.cs

@@ -143,5 +143,16 @@ public bool SupportsSqlType(SqlType sqlType)
 		/// Some databases fail when a connection is enlisted during the first phase of a two phase commit.
 		/// </summary>
 		public virtual bool SupportsUsingConnectionOnSystemTransactionPrepare => true;
+
+		/// <summary>
+		/// Some databases (provider?) fails to compute adequate column types for queries which columns
+		/// computing include a parameter value.
+		/// </summary>
+		/// <remarks>
+		/// This property is not set to true for Firebird although it seems to be affected too. But its driver
+		/// currently has a hack for casting all parameters in select and where clauses in order to explicit
+		/// their type in the query.
+		/// </remarks>
+		public virtual bool HasBrokenTypeInferenceOnSelectedParameters => false;
 	}
 }