Skip to content

Commit 0d54533

Browse files
fix(routes/show): add basic css responsive design
This patch adds a basic CSS-only responsive design to the show page. There is still much room for improvement (I should probably swap out entire components when on mobile), but this works OK for now and is an improvement over what was previously unusable on mobile. Closes: NC-734
1 parent cd51aed commit 0d54533

File tree

2 files changed

+26
-13
lines changed

2 files changed

+26
-13
lines changed

app/routes/_header.shows.$seasonYear.$seasonName.($sex).$brandSlug/route.tsx

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,19 +126,29 @@ export default function ShowPage() {
126126
const aboutFlexGrow = aboutWidth / looksWidth
127127
const looksFlexGrow = 1
128128
return (
129-
<main className='fixed inset-0 overflow-hidden flex'>
130-
<div className='w-0 overflow-auto' style={{ flexGrow: aboutFlexGrow }}>
129+
<main className='sm:fixed sm:inset-0 sm:overflow-hidden sm:flex sm:p-0 p-6'>
130+
<div
131+
className='sm:w-0 sm:overflow-auto'
132+
style={{ flexGrow: aboutFlexGrow }}
133+
>
131134
<div
132-
className='pt-16 pl-6 pb-6 ml-auto w-full'
133-
style={{ maxWidth: maxWidth * about }}
135+
className='sm:pt-16 sm:pl-6 pb-6 sm:ml-auto w-full'
136+
style={{
137+
maxWidth: viewportWidth > maxWidth ? maxWidth * about : undefined,
138+
}}
134139
>
135140
<About />
136141
</div>
137142
</div>
138-
<div className='w-0 overflow-auto' style={{ flexGrow: looksFlexGrow }}>
143+
<div
144+
className='sm:w-0 sm:overflow-auto'
145+
style={{ flexGrow: looksFlexGrow }}
146+
>
139147
<div
140-
className='px-6 pt-16 pb-6 mr-auto w-full'
141-
style={{ maxWidth: maxWidth * looks }}
148+
className='sm:px-6 sm:pt-16 sm:pb-6 sm:mr-auto w-full sm:max-w-auto'
149+
style={{
150+
maxWidth: viewportWidth > maxWidth ? maxWidth * looks : undefined,
151+
}}
142152
>
143153
<Looks />
144154
</div>

app/routes/_header.shows.$seasonYear.$seasonName.($sex).$brandSlug/scores-header.tsx

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export function ScoresHeader() {
4646
)}
4747
</div>
4848
<article className='flex-1 bg-gray-100 dark:bg-gray-900 text-center px-6 flex flex-col'>
49-
<h1 className='font-serif font-bold text-5xl mb-1 mt-8'>
49+
<h1 className='font-serif font-bold text-2xl md:text-3xl lg:text-5xl mb-1 mt-8'>
5050
{show.brand.name}
5151
</h1>
5252
<h2 className='uppercase mb-6 text-sm'>{getShowSeason(show)}</h2>
@@ -76,16 +76,19 @@ function ScoreItem({ score, name }: ScoreItemProps) {
7676
return (
7777
<li className='flex gap-2 justify-center'>
7878
<img
79-
className={cn('flex-none w-20', score.totalCount === 0 && 'grayscale')}
79+
className={cn(
80+
'hidden lg:block flex-none w-20',
81+
score.totalCount === 0 && 'grayscale',
82+
)}
8083
src={`/flowers/${img}.png`}
8184
alt=''
8285
/>
83-
<div>
84-
<h2 className='text-5xl font-black font-serif'>
86+
<div className='mb-6 lg:mb-0'>
87+
<h2 className='text-3xl lg:text-5xl font-black font-serif'>
8588
{score.totalCount === 0 ? '--' : `${num}%`}
8689
</h2>
87-
<p className='text-xs font-semibold uppercase'>{name}</p>
88-
<p className='text-xs'>
90+
<p className='text-3xs lg:text-xs font-semibold uppercase'>{name}</p>
91+
<p className='text-3xs lg:text-xs'>
8992
{score.totalCount === 0
9093
? 'No Reviews'
9194
: `${score.totalCount} Reviews`}

0 commit comments

Comments
 (0)