ApiProblem::fromException use empty instead isset

mbabjak · mbabjak · commit 64e521055234 · 2016-06-17T10:50:33.000+02:00
diff --git a/src/ApiProblem/ApiProblem.php b/src/ApiProblem/ApiProblem.php
@@ -128,7 +128,7 @@ public function __construct($status, $detail, $title = '', $type = '', array $ad
     public static function fromException(Exception $exception, $title = '', $type = '', array $additionalDetails = [])
     {
         $eCode = $exception->getCode();
-        $code = (isset($eCode) && is_int($eCode)) ? $eCode : 500;
+        $code = (!empty($eCode) && is_int($eCode)) ? $eCode : 500;
 
         if (0 === strlen($title) && 0 === strlen($type) && array_key_exists($code, self::$problemStatus)) {
             $title = (self::$problemStatus[$code]);

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ public function __construct($status, $detail, $title = '', $type = '', array $ad`
`128`	`128`	`public static function fromException(Exception $exception, $title = '', $type = '', array $additionalDetails = [])`
`129`	`129`	`{`
`130`	`130`	`$eCode = $exception->getCode();`
`131`		`- $code = (isset($eCode) && is_int($eCode)) ? $eCode : 500;`
	`131`	`+ $code = (!empty($eCode) && is_int($eCode)) ? $eCode : 500;`
`132`	`132`
`133`	`133`	`if (0 === strlen($title) && 0 === strlen($type) && array_key_exists($code, self::$problemStatus)) {`
`134`	`134`	`$title = (self::$problemStatus[$code]);`