Improves copy

Author: jmgomez

src/nimblepkg/tools.nim

@@ -134,8 +134,20 @@ proc changeRoot*(origRoot, newRoot, path: string): string =
 proc copyFileD*(fro, to: string): string =
   ## Returns the destination (``to``).
   display("Copying", "file $# to $#" % [fro, to], priority = LowPriority)
-  copyFileWithPermissions(fro, to)
-  result = to
+  try:
+    copyFileWithPermissions(fro, to)
+    result = to
+  except OSError as e:
+    # Try to copy without preserving permissions for files with restrictive permissions
+    # This can happen with .git pack files
+    try:
+      copyFile(fro, to)
+      result = to
+    except OSError:
+      # If we still can't copy, skip with a warning but don't fail the entire operation
+      # This allows installation to continue even if some .git metadata files can't be copied
+      display("Warning", "Skipped file $# (permission denied)" % fro, priority = LowPriority)
+      result = to  # Return the destination path even if copy failed
 
 proc copyDirD*(fro, to: string): seq[string] =
   ## Returns the filenames of the files in the directory that were copied.

src/nimblepkg/version.nim

@@ -353,7 +353,6 @@ proc getSimpleString*(verRange: VersionRange): string =
   case verRange.kind
   of verSpecial:
     result = $verRange.spe
-    # Remove '#' prefix for directory names (can cause issues with shell commands)
     if result.startsWith("#"):
       result = result[1..^1]
   of verLater, verEarlier, verEqLater, verEqEarlier, verEq: