fix: cover one more edge case (nipype.interfaces.base.DictStrStr)

Author: oesteban

nipype/interfaces/base/tests/test_traits_extension.py

@@ -20,6 +20,7 @@ class _test_spec(nib.TraitedSpec):
     i = nib.traits.Either(nib.File, nib.traits.Tuple(nib.File, nib.traits.Int))
     j = nib.traits.Either(nib.File, nib.traits.Tuple(nib.File, nib.traits.Int),
                           nib.traits.Dict(nib.Str, nib.File()))
+    k = nib.DictStrStr
 
 
 def test_rebase_resolve_path_traits():
@@ -209,7 +210,6 @@ def test_rebase_resolve_path_traits():
     # Idempotence
     assert resolve_path_traits(spec.trait('g'), g, '/some') == g
 
-    v = v
     g = rebase_path_traits(spec.trait('g'), v, '/some/path')
     assert g == v  # You dont want this one to be a Path
 
@@ -300,3 +300,13 @@ def test_rebase_resolve_path_traits():
 
     # Idempotence
     assert resolve_path_traits(spec.trait('j'), j, '/some/path') == j
+
+    v = {'path': '/some/path/f1.txt'}
+    k = rebase_path_traits(spec.trait('k'), v, '/some/path')
+    assert k == v
+
+    # Idempotence
+    assert rebase_path_traits(spec.trait('k'), k, '/some/path') == k
+
+    k = resolve_path_traits(spec.trait('k'), k, '/some/path')
+    assert k == v

nipype/interfaces/base/traits_extension.py

@@ -520,7 +520,12 @@ def _recurse_on_path_traits(func, thistrait, value, cwd):
             return value
 
         for subtrait in thistrait.handler.handlers:
-            value = _recurse_on_path_traits(func, subtrait(), value, cwd)
+            try:
+                sb_instance = subtrait()
+            except TypeError:
+                return value
+            else:
+                value = _recurse_on_path_traits(func, sb_instance, value, cwd)
 
     return value