Skip to content

Commit 339b725

Browse files
Use using statement to dispose the stream
1 parent 3cd6b9b commit 339b725

File tree

1 file changed

+36
-35
lines changed

1 file changed

+36
-35
lines changed

Test/Notion.IntegrationTests/FileUploadsClientTests.cs

Lines changed: 36 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -82,43 +82,44 @@ public async Task Verify_multi_part_file_upload_flow()
8282
Assert.Equal("pending", createResponse.Status);
8383

8484
// Send file parts
85-
var fileStream = File.OpenRead("assets/notion-logo.png");
86-
var splitStreams = StreamSplitExtensions.Split(fileStream, 2);
87-
fileStream.Close();
88-
89-
foreach (var (partStream, index) in splitStreams.WithIndex())
85+
using (var fileStream = File.OpenRead("assets/notion-logo.png"))
9086
{
91-
var partSendRequest = SendFileUploadRequest.Create(
92-
createResponse.Id,
93-
new FileData
94-
{
95-
FileName = "notion-logo.png",
96-
Data = partStream,
97-
ContentType = createResponse.ContentType
98-
},
99-
100-
partNumber: (index + 1).ToString()
101-
);
102-
103-
var partSendResponse = await Client.FileUploads.SendAsync(partSendRequest);
104-
105-
Assert.NotNull(partSendResponse);
106-
Assert.Equal(createResponse.Id, partSendResponse.Id);
107-
Assert.Equal("notion-logo.png", partSendResponse.FileName);
87+
var splitStreams = StreamSplitExtensions.Split(fileStream, 2);
88+
89+
foreach (var (partStream, index) in splitStreams.WithIndex())
90+
{
91+
var partSendRequest = SendFileUploadRequest.Create(
92+
createResponse.Id,
93+
new FileData
94+
{
95+
FileName = "notion-logo.png",
96+
Data = partStream,
97+
ContentType = createResponse.ContentType
98+
},
99+
100+
partNumber: (index + 1).ToString()
101+
);
102+
103+
var partSendResponse = await Client.FileUploads.SendAsync(partSendRequest);
104+
105+
Assert.NotNull(partSendResponse);
106+
Assert.Equal(createResponse.Id, partSendResponse.Id);
107+
Assert.Equal("notion-logo.png", partSendResponse.FileName);
108+
}
109+
110+
// Complete file upload
111+
var completeRequest = new CompleteFileUploadRequest
112+
{
113+
FileUploadId = createResponse.Id
114+
};
115+
116+
var completeResponse = await Client.FileUploads.CompleteAsync(completeRequest);
117+
118+
Assert.NotNull(completeResponse);
119+
Assert.Equal(createResponse.Id, completeResponse.Id);
120+
Assert.Equal("notion-logo.png", completeResponse.FileName);
121+
Assert.Equal("completed", completeResponse.Status);
108122
}
109-
110-
// Complete file upload
111-
var completeRequest = new CompleteFileUploadRequest
112-
{
113-
FileUploadId = createResponse.Id
114-
};
115-
116-
var completeResponse = await Client.FileUploads.CompleteAsync(completeRequest);
117-
118-
Assert.NotNull(completeResponse);
119-
Assert.Equal(createResponse.Id, completeResponse.Id);
120-
Assert.Equal("notion-logo.png", completeResponse.FileName);
121-
Assert.Equal("completed", completeResponse.Status);
122123
}
123124
}
124125
}

0 commit comments

Comments
 (0)