Skip to content

Commit 7cc2908

Browse files
remove try catch - let the exception bubble up.
This help caller to get read the NotionApiException and handle as per their need.
1 parent 3ce7a3c commit 7cc2908

File tree

2 files changed

+13
-48
lines changed

2 files changed

+13
-48
lines changed

Src/Notion.Client/Api/Databases/DatabasesClient.cs

Lines changed: 11 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -23,48 +23,27 @@ public DatabasesClient(IRestClient client)
2323

2424
public async Task<Database> RetrieveAsync(string databaseId)
2525
{
26-
try
27-
{
28-
return await _client.GetAsync<Database>(DatabasesApiUrls.Retrieve(databaseId));
29-
}
30-
catch (Exception e)
31-
{
32-
// Todo: Throw Custom Exception
33-
return null;
34-
}
26+
return await _client.GetAsync<Database>(DatabasesApiUrls.Retrieve(databaseId));
3527
}
3628

3729
public async Task<PaginatedList<Database>> ListAsync(DatabasesListParameters databasesListParameters = null)
3830
{
39-
try
40-
{
41-
var databasesListQueryParmaters = (IDatabasesListQueryParmaters)databasesListParameters;
42-
var queryParams = new Dictionary<string, string>()
43-
{
44-
{ "start_cursor", databasesListQueryParmaters?.StartCursor },
45-
{ "page_size", databasesListQueryParmaters?.PageSize }
46-
};
31+
var databasesListQueryParmaters = (IDatabasesListQueryParmaters)databasesListParameters;
4732

48-
return await _client.GetAsync<PaginatedList<Database>>(DatabasesApiUrls.List(), queryParams);
49-
}
50-
catch (Exception e)
33+
var queryParams = new Dictionary<string, string>()
5134
{
52-
// Todo: Throw Custom Exception
53-
return null;
54-
}
35+
{ "start_cursor", databasesListQueryParmaters?.StartCursor },
36+
{ "page_size", databasesListQueryParmaters?.PageSize }
37+
};
38+
39+
return await _client.GetAsync<PaginatedList<Database>>(DatabasesApiUrls.List(), queryParams);
5540
}
5641

5742
public async Task<PaginatedList<Page>> QueryAsync(string databaseId, DatabasesQueryParameters databasesQueryParameters)
5843
{
59-
try
60-
{
61-
var body = (IDatabaseQueryBodyParameters)databasesQueryParameters;
62-
return await _client.PostAsync<PaginatedList<Page>>(DatabasesApiUrls.Query(databaseId), body);
63-
}
64-
catch (Exception e)
65-
{
66-
return null;
67-
}
44+
var body = (IDatabaseQueryBodyParameters)databasesQueryParameters;
45+
46+
return await _client.PostAsync<PaginatedList<Page>>(DatabasesApiUrls.Query(databaseId), body);
6847
}
6948
}
7049
}

Src/Notion.Client/Api/Users/UsersClient.cs

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,26 +21,12 @@ public UsersClient(IRestClient client)
2121

2222
public async Task<User> RetrieveAsync(string userId)
2323
{
24-
try
25-
{
26-
return await _client.GetAsync<User>(UsersApiUrls.Retrieve(userId));
27-
}
28-
catch (Exception e)
29-
{
30-
return null;
31-
}
24+
return await _client.GetAsync<User>(UsersApiUrls.Retrieve(userId));
3225
}
3326

3427
public async Task<PaginatedList<User>> ListAsync()
3528
{
36-
try
37-
{
38-
return await _client.GetAsync<PaginatedList<User>>(UsersApiUrls.List());
39-
}
40-
catch (Exception e)
41-
{
42-
return null;
43-
}
29+
return await _client.GetAsync<PaginatedList<User>>(UsersApiUrls.List());
4430
}
4531
}
4632
}

0 commit comments

Comments
 (0)