Skip to content

Commit a96af1a

Browse files
committed
Updates from PR review
1 parent 744229d commit a96af1a

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

Src/Notion.Client/Api/Authentication/IAuthenticationClient.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ Task<CreateTokenResponse> CreateTokenAsync(
1818
CreateTokenRequest createTokenRequest,
1919
CancellationToken cancellationToken = default
2020
);
21-
21+
2222
/// <summary>
2323
/// Revokes an access token.
2424
/// </summary>
2525
/// <param name="revokeTokenRequest"></param>
2626
/// <param name="cancellationToken"></param>
2727
/// <returns></returns>
28-
Task<CreateTokenResponse> RevokeTokenAsync(
28+
Task RevokeTokenAsync(
2929
RevokeTokenRequest revokeTokenRequest,
3030
CancellationToken cancellationToken = default
3131
);
Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,30 @@
1+
using System.Net.Http;
12
using System.Threading;
23
using System.Threading.Tasks;
34

45
namespace Notion.Client
56
{
67
public sealed partial class AuthenticationClient
7-
{
8-
public async Task<HttpStatusCode> RevokeTokenAsync(
8+
{
9+
public async Task RevokeTokenAsync(
910
RevokeTokenRequest revokeTokenRequest,
1011
CancellationToken cancellationToken = default)
1112
{
1213
var body = (IRevokeTokenBodyParameters)revokeTokenRequest;
13-
14-
return (await _client.PostAsync(
14+
15+
var response = await _client.PostAsync<HttpResponseMessage>(
1516
ApiEndpoints.AuthenticationUrls.RevokeToken(),
1617
body,
1718
cancellationToken: cancellationToken
18-
)).StatusCode;
19+
);
20+
21+
if (!response.IsSuccessStatusCode)
22+
{
23+
throw new NotionApiException(response.StatusCode,
24+
null,
25+
"None success status code returned from revoke endpoint"
26+
);
27+
}
1928
}
2029
}
2130
}

0 commit comments

Comments
 (0)