code refactor ♻️

Author: KoditkarVedant

Src/Notion.Client/Api/Blocks/BlocksAppendChildrenParameters.cs

@@ -0,0 +1,15 @@
+using System.Collections.Generic;
+
+namespace Notion.Client
+{
+    // TODO: need an input version of Block
+    public interface IBlocksAppendChildrenBodyParameters
+    {
+        IEnumerable<BlockBase> Children { get; set; }
+    }
+
+    public class BlocksAppendChildrenParameters : IBlocksAppendChildrenBodyParameters
+    {
+        public IEnumerable<BlockBase> Children { get; set; }
+    }
+}

Src/Notion.Client/Api/Blocks/BlocksClient.cs

@@ -7,7 +7,7 @@ namespace Notion.Client
 {
     public interface IBlocksClient
     {
-        Task<PaginatedList<BlockBase>> RetrieveChildrenAsync(string blockId, BlockRetrieveChildrenParameters parameters = null);
+        Task<PaginatedList<BlockBase>> RetrieveChildrenAsync(string blockId, BlocksRetrieveChildrenParameters parameters = null);
         Task<BlockBase> AppendChildrenAsync(string blockId, BlocksAppendChildrenParameters parameters = null);
     }
 
@@ -20,7 +20,7 @@ public BlocksClient(IRestClient client)
             _client = client;
         }
 
-        public async Task<PaginatedList<BlockBase>> RetrieveChildrenAsync(string blockId, BlockRetrieveChildrenParameters parameters = null)
+        public async Task<PaginatedList<BlockBase>> RetrieveChildrenAsync(string blockId, BlocksRetrieveChildrenParameters parameters = null)
         {
             if (string.IsNullOrWhiteSpace(blockId))
             {
@@ -29,7 +29,7 @@ public async Task<PaginatedList<BlockBase>> RetrieveChildrenAsync(string blockId
 
             var url = BlocksApiUrls.RetrieveChildren(blockId);
 
-            var queryParameters = (IBlockRetrieveChildrenQueryParameters)parameters;
+            var queryParameters = (IBlocksRetrieveChildrenQueryParameters)parameters;
 
             var queryParams = new Dictionary<string, string>()
             {
@@ -54,30 +54,4 @@ public async Task<BlockBase> AppendChildrenAsync(string blockId, BlocksAppendChi
             return await _client.PatchAsync<BlockBase>(url, body);
         }
     }
-
-    public interface IBlockRetrieveChildrenQueryParameters : IPaginationParameters
-    {
-    }
-
-    public interface IBlockRetrieveChildrenParameters : IBlockRetrieveChildrenQueryParameters
-    {
-    }
-
-    public class BlockRetrieveChildrenParameters : IBlockRetrieveChildrenParameters
-    {
-        public string StartCursor { get; set; }
-        public string PageSize { get; set; }
-    }
-
-
-    // TODO: need an input version of Block
-    public interface IBlocksAppendChildrenBodyParameters
-    {
-        IEnumerable<BlockBase> Children { get; set; }
-    }
-
-    public class BlocksAppendChildrenParameters : IBlocksAppendChildrenBodyParameters
-    {
-        public IEnumerable<BlockBase> Children { get; set; }
-    }
 }

Src/Notion.Client/Api/Blocks/BlocksRetrieveChildrenParameters.cs

@@ -0,0 +1,12 @@
+namespace Notion.Client
+{
+    public interface IBlocksRetrieveChildrenQueryParameters : IPaginationParameters
+    {
+    }
+
+    public class BlocksRetrieveChildrenParameters : IBlocksRetrieveChildrenQueryParameters
+    {
+        public string StartCursor { get; set; }
+        public string PageSize { get; set; }
+    }
+}

Src/Notion.Client/Models/Block.cs

@@ -35,7 +35,6 @@ public class BlockBase
 
         [JsonProperty("has_children")]
         public virtual bool HasChildren { get; set; }
-
     }
 
     public class ParagraphBlock : BlockBase
@@ -160,7 +159,6 @@ public class ChildPageBlock : BlockBase
     {
         public override BlockType Type => BlockType.ChildPage;
 
-
         [JsonProperty("child_page")]
         public ChildPageClass ChildPage { get; set; }
 

Test/Notion.UnitTests/BlocksClientTests.cs

@@ -24,7 +24,7 @@ public async Task RetrieveBlockChildren()
         {
             string blockId = "3c357473-a281-49a4-88c0-10d2b245a589";
 
-            var children = await _client.RetrieveChildrenAsync(blockId, new BlockRetrieveChildrenParameters());
+            var children = await _client.RetrieveChildrenAsync(blockId, new BlocksRetrieveChildrenParameters());
 
             Assert.NotNull(children);
         }