Merge pull request #179 from notion-dotnet/bfix/178-cannot-insert-page-with-select-property

Fix: Cannot insert page with select property 🐛

Author: KoditkarVedant

Src/Notion.Client/Models/Database/Properties/SelectProperty.cs

@@ -36,7 +36,7 @@ public class SelectOption
         /// </summary>
         [JsonProperty("color")]
         [JsonConverter(typeof(StringEnumConverter))]
-        public Color Color { get; set; }
+        public Color? Color { get; set; }
     }
 
     public enum Color

Src/Notion.Client/Notion.Client.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <VersionPrefix>2.0.1-preview</VersionPrefix>
+    <VersionPrefix>2.2.1-preview</VersionPrefix>
     <TargetFramework>netstandard2.0</TargetFramework>
     <LangVersion>7.3</LangVersion>
 

Test/Notion.IntegrationTests/IPageClientTests.cs

@@ -54,5 +54,57 @@ public async Task CreateAsync_CreatesANewPage()
                 Archived = true
             });
         }
+
+        [Fact]
+        public async Task Bug_unable_to_create_page_with_select_property()
+        {
+            var options = new ClientOptions
+            {
+                AuthToken = Environment.GetEnvironmentVariable("NOTION_AUTH_TOKEN")
+            };
+
+            INotionClient _client = new NotionClient(options);
+
+            PagesCreateParameters pagesCreateParameters = PagesCreateParametersBuilder.Create(new DatabaseParentInput
+            {
+                DatabaseId = "f86f2262-0751-40f2-8f63-e3f7a3c39fcb"
+            })
+            .AddProperty("Name", new TitlePropertyValue
+            {
+                Title = new List<RichTextBase>
+                {
+                    new RichTextText
+                    {
+                        Text = new Text
+                        {
+                            Content = "Test Page Title"
+                        }
+                    }
+                }
+            })
+            .AddProperty("TestSelect", new SelectPropertyValue
+            {
+                Select = new SelectOption
+                {
+                    Id = "dfbfbe65-6f67-4876-9f75-699124334d06"
+                }
+            })
+            .Build();
+
+            var page = await _client.Pages.CreateAsync(pagesCreateParameters);
+
+            page.Should().NotBeNull();
+            page.Parent.Should().BeOfType<DatabaseParent>().Which
+                .DatabaseId.Should().Be("f86f2262-0751-40f2-8f63-e3f7a3c39fcb");
+
+            page.Properties.Should().ContainKey("Name");
+            page.Properties["Name"].Should().BeOfType<TitlePropertyValue>().Which
+                .Title.First().PlainText.Should().Be("Test Page Title");
+
+            await _client.Pages.UpdateAsync(page.Id, new PagesUpdateParameters
+            {
+                Archived = true
+            });
+        }
     }
 }