Merge pull request #228 from Titaye/fix/database_id_typo

Fix wrong field used in relation field 🔨

Author: KoditkarVedant

Src/Notion.Client/Models/Database/Properties/RelationProperty.cs

@@ -13,7 +13,7 @@ public class RelationProperty : Property
 
     public class Relation
     {
-        [JsonProperty("datebase_id")]
+        [JsonProperty("database_id")]
         public string DatabaseId { get; set; }
 
         [JsonProperty("synced_property_name")]

Test/Notion.UnitTests/DatabasesClientTests.cs

@@ -146,6 +146,36 @@ public async Task DatabasePropertyObjectContainNameProperty()
             }
         }
 
+        [Fact]
+        public async Task DatabasePropertyObjectContainRelationProperty()
+        {
+            var databaseId = "f0212efc-caf6-4afc-87f6-1c06f1dfc8a1";
+            var path = ApiEndpoints.DatabasesApiUrls.Retrieve(databaseId);
+            var jsonData = await File.ReadAllTextAsync("data/databases/DatabasePropertyObjectContainRelation.json");
+
+            Server.Given(CreateGetRequestBuilder(path))
+                .RespondWith(
+                Response.Create()
+                    .WithStatusCode(200)
+                    .WithBody(jsonData)
+            );
+
+            var database = await _client.RetrieveAsync(databaseId);
+
+            database.Properties.Should().ContainKey("Property").WhichValue.Should().BeEquivalentTo(
+                    new RelationProperty()
+                    {
+                        Id = "zDGa",
+                        Name = "Property",
+                        Relation = new Relation()
+                        {
+                            DatabaseId = "f86f2262-0751-40f2-8f63-e3f7a3c39fcb",
+                            SyncedPropertyName = "Related to sample table (Property)",
+                            SyncedPropertyId = "VQ}{"
+                        }
+                    });
+        }
+
         [Fact]
         public async Task DatabasePropertyObjectContainParentProperty()
         {

Test/Notion.UnitTests/Notion.UnitTests.csproj

@@ -93,6 +93,9 @@
     <None Update="data\databases\FormulaPropertyCanBeSetWhenCreatingDatabaseResponse.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
+    <None Update="data\databases\DatabasePropertyObjectContainRelation.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
   </ItemGroup>
 
 </Project>

Test/Notion.UnitTests/data/databases/DatabasePropertyObjectContainRelation.json

@@ -0,0 +1,89 @@
+{
+  "object": "database",
+  "id": "f0212efc-caf6-4afc-87f6-1c06f1dfc8a1",
+  "created_time": "2021-05-22T18:44:00.000Z",
+  "last_edited_time": "2021-05-23T12:29:00.000Z",
+  "title": [
+    {
+      "type": "text",
+      "text": {
+        "content": "sample table",
+        "link": null
+      },
+      "annotations": {
+        "bold": false,
+        "italic": false,
+        "strikethrough": false,
+        "underline": false,
+        "code": false,
+        "color": "default"
+      },
+      "plain_text": "sample table",
+      "href": null
+    }
+  ],
+  "properties": {
+    "Tags": {
+      "id": "YG~h",
+      "name": "Tags",
+      "type": "multi_select",
+      "multi_select": {
+        "options": []
+      }
+    },
+    "SimpleText": {
+      "id": "_Dfp",
+      "name": "SimpleText",
+      "type": "rich_text",
+      "rich_text": {}
+    },
+    "Column": {
+      "id": "bxhl",
+      "name": "Column",
+      "type": "multi_select",
+      "multi_select": {
+        "options": [
+          {
+            "id": "5a44a233-33be-435e-b358-2c0ed1799dcf",
+            "name": "what",
+            "color": "gray"
+          }
+        ]
+      }
+    },
+    "SelectProp": {
+      "id": "eZ[y",
+      "name": "SelectProp",
+      "type": "select",
+      "select": {
+        "options": [
+          {
+            "id": "362dc255-c867-4543-b3ea-7bd988638228",
+            "name": "Female",
+            "color": "green"
+          }
+        ]
+      }
+    },
+    "Property": {
+      "id": "zDGa",
+      "name": "Property",
+      "type": "relation",
+      "relation": {
+        "database_id": "f86f2262-0751-40f2-8f63-e3f7a3c39fcb",
+        "synced_property_name": "Related to sample table (Property)",
+        "synced_property_id": "VQ}{"
+      }
+    },
+    "Name": {
+      "id": "title",
+      "name": "Name",
+      "type": "title",
+      "title": {}
+    }
+  },
+  "parent": {
+    "type": "page_id",
+    "page_id": "649089db-8984-4051-98fb-a03593b852d8"
+  }
+}