Merge pull request #20 from notion-dotnet/fix-code-factor-issues

Fix code factor issues ♻️

Author: KoditkarVedant

Src/Notion.Client/Api/Blocks/BlocksAppendChildrenParameters.cs

@@ -5,12 +5,6 @@
 
 namespace Notion.Client
 {
-    public interface IBlocksClient
-    {
-        Task<PaginatedList<BlockBase>> RetrieveChildrenAsync(string blockId, BlocksRetrieveChildrenParameters parameters = null);
-        Task<BlockBase> AppendChildrenAsync(string blockId, BlocksAppendChildrenParameters parameters = null);
-    }
-
     public class BlocksClient : IBlocksClient
     {
         private readonly IRestClient _client;
@@ -20,7 +14,7 @@ public BlocksClient(IRestClient client)
             _client = client;
         }
 
-        public async Task<PaginatedList<BlockBase>> RetrieveChildrenAsync(string blockId, BlocksRetrieveChildrenParameters parameters = null)
+        public async Task<PaginatedList<Block>> RetrieveChildrenAsync(string blockId, BlocksRetrieveChildrenParameters parameters = null)
         {
             if (string.IsNullOrWhiteSpace(blockId))
             {
@@ -37,10 +31,10 @@ public async Task<PaginatedList<BlockBase>> RetrieveChildrenAsync(string blockId
                 { "page_size", queryParameters?.PageSize?.ToString() }
             };
 
-            return await _client.GetAsync<PaginatedList<BlockBase>>(url, queryParams);
+            return await _client.GetAsync<PaginatedList<Block>>(url, queryParams);
         }
 
-        public async Task<BlockBase> AppendChildrenAsync(string blockId, BlocksAppendChildrenParameters parameters = null)
+        public async Task<Block> AppendChildrenAsync(string blockId, BlocksAppendChildrenParameters parameters = null)
         {
             if (string.IsNullOrWhiteSpace(blockId))
             {
@@ -51,7 +45,7 @@ public async Task<BlockBase> AppendChildrenAsync(string blockId, BlocksAppendChi
 
             var body = (IBlocksAppendChildrenBodyParameters)parameters;
 
-            return await _client.PatchAsync<BlockBase>(url, body);
+            return await _client.PatchAsync<Block>(url, body);
         }
     }
-}
+}

Src/Notion.Client/Api/Blocks/BlocksClient.cs

@@ -0,0 +1,10 @@
+using System.Threading.Tasks;
+
+namespace Notion.Client
+{
+    public interface IBlocksClient
+    {
+        Task<PaginatedList<Block>> RetrieveChildrenAsync(string blockId, BlocksRetrieveChildrenParameters parameters = null);
+        Task<Block> AppendChildrenAsync(string blockId, BlocksAppendChildrenParameters parameters = null);
+    }
+}

Src/Notion.Client/Api/Blocks/IBlocksClient.cs

@@ -0,0 +1,9 @@
+using System.Collections.Generic;
+
+namespace Notion.Client
+{
+    public class BlocksAppendChildrenParameters : IBlocksAppendChildrenBodyParameters
+    {
+        public IEnumerable<Block> Children { get; set; }
+    }
+}

Src/Notion.Client/Api/Blocks/RequestParams/BlocksAppendChildrenParameters.cs

@@ -1,12 +1,8 @@
 namespace Notion.Client
 {
-    public interface IBlocksRetrieveChildrenQueryParameters : IPaginationParameters
-    {
-    }
-
     public class BlocksRetrieveChildrenParameters : IBlocksRetrieveChildrenQueryParameters
     {
         public string StartCursor { get; set; }
         public string PageSize { get; set; }
     }
-}
+}

Src/Notion.Client/Api/Blocks/BlocksRetrieveChildrenParameters.cs renamed to Src/Notion.Client/Api/Blocks/RequestParams/BlocksRetrieveChildrenParameters.cs

@@ -0,0 +1,10 @@
+using System.Collections.Generic;
+
+namespace Notion.Client
+{
+    // TODO: need an input version of Block
+    public interface IBlocksAppendChildrenBodyParameters
+    {
+        IEnumerable<Block> Children { get; set; }
+    }
+}

Src/Notion.Client/Api/Blocks/RequestParams/IBlocksAppendChildrenBodyParameters.cs

@@ -0,0 +1,6 @@
+namespace Notion.Client
+{
+    public interface IBlocksRetrieveChildrenQueryParameters : IPaginationParameters
+    {
+    }
+}

Src/Notion.Client/Api/Blocks/RequestParams/IBlocksRetrieveChildrenQueryParameters.cs

@@ -1,17 +1,9 @@
-using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
 using static Notion.Client.ApiEndpoints;
 
 namespace Notion.Client
 {
-    public interface IDatabasesClient
-    {
-        Task<Database> RetrieveAsync(string databaseId);
-        Task<PaginatedList<Page>> QueryAsync(string databaseId, DatabasesQueryParameters databasesQueryParameters);
-        Task<PaginatedList<Database>> ListAsync(DatabasesListParameters databasesListParameters = null);
-    }
-
     public class DatabasesClient : IDatabasesClient
     {
         private readonly IRestClient _client;

Src/Notion.Client/Api/Databases/DatabasesClient.cs

@@ -0,0 +1,11 @@
+using System.Threading.Tasks;
+
+namespace Notion.Client
+{
+    public interface IDatabasesClient
+    {
+        Task<Database> RetrieveAsync(string databaseId);
+        Task<PaginatedList<Page>> QueryAsync(string databaseId, DatabasesQueryParameters databasesQueryParameters);
+        Task<PaginatedList<Database>> ListAsync(DatabasesListParameters databasesListParameters = null);
+    }
+}

Src/Notion.Client/Api/Databases/IDatabasesClient.cs

@@ -0,0 +1,8 @@
+namespace Notion.Client
+{
+    public class DatabasesListParameters : IDatabasesListQueryParmaters
+    {
+        public string StartCursor { get; set; }
+        public string PageSize { get; set; }
+    }
+}