test(all): improve test coverage

Author: solkimicreb

src/context.js

@@ -9,7 +9,6 @@ else if (typeof global !== 'undefined') globalObj = global // eslint-disable-lin
 else if (typeof self !== 'undefined') globalObj = self // eslint-disable-line
 globalObj.$nxCompileToSandbox = toSandbox
 globalObj.$nxClearSandbox = clearSandbox
-globalObj.$nxGlobals = globals
 
 export function expose (...globalNames) {
   for (let globalName of globalNames) {

src/parser.js

@@ -16,7 +16,7 @@ export function parseExpression (src) {
     filters: []
   }
   for (let i = 1; i < tokens.length; i++) {
-    let filterTokens = tokens[i].match(argsRegex) || []
+    let filterTokens = tokens[i].match(argsRegex)
     const filterName = filterTokens.shift()
     const effect = filters.get(filterName)
     if (!effect) {
@@ -38,7 +38,7 @@ export function parseCode (src) {
     limiters: []
   }
   for (let i = 1; i < tokens.length; i++) {
-    const limiterTokens = tokens[i].match(argsRegex) || []
+    const limiterTokens = tokens[i].match(argsRegex)
     const limiterName = limiterTokens.shift()
     const effect = limiters.get(limiterName)
     if (!effect) {

test/compiler.js

@@ -19,9 +19,9 @@ describe('compiler', () => {
 
   describe('compileExpression()', () => {
     it('should throw a TypeError on non string source argument', () => {
-      expect(() => compiler.compileCode({})).to.throw(TypeError)
-      expect(() => compiler.compileCode(undefined)).to.throw(TypeError)
-      expect(() => compiler.compileCode(12)).to.throw(TypeError)
+      expect(() => compiler.compileExpression({})).to.throw(TypeError)
+      expect(() => compiler.compileExpression(undefined)).to.throw(TypeError)
+      expect(() => compiler.compileExpression(12)).to.throw(TypeError)
     })
   })
 

test/modifiers.js

@@ -36,6 +36,10 @@ describe('context', () => {
       const expression = compiler.compileExpression('message | slice 1 4 | capitalize')
       expect(expression({message: 'hello'})).to.equal('ELL')
     })
+
+    it('should throw an error on using unregistered filters', () => {
+      expect(() => compiler.compileExpression('message | unregisteredFilter')).to.throw(Error)
+    })
   })
 
   describe('limiter', () => {
@@ -134,4 +138,8 @@ describe('context', () => {
       expect(context.counter).to.equal(2)
     })
   })
+
+  it('should throw an error on using unregistered limiters', () => {
+    expect(() => compiler.compileCode('return message & unregisteredLimiter')).to.throw(Error)
+  })
 })