Merge pull request #40 from oblakstudio/feat/puppeteer-v23

Added support for Puppeteer v23 and v22

Author: seebeen

.github/workflows/pull_request.yml

@@ -21,8 +21,6 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - 18
-          - 19
           - 20
           - 21
     runs-on: ubuntu-latest
@@ -40,7 +38,7 @@ jobs:
       - run: npm clean-install
       - name: Ensure dependencies are compatible with the version of node
         run: npx ls-engines
-      - run: npm run test:e2e
+      - run: aa-exec --profile=chrome npm run test:e2e
 
   test:
     runs-on: ubuntu-latest
@@ -67,7 +65,7 @@ jobs:
           node-version: lts/*
           cache: npm
       - run: npm clean-install
-      - run: npm run test:e2e:cov
+      - run: aa-exec --profile=chrome npm run test:e2e:cov
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v3
         env:

.github/workflows/release.yml

@@ -30,7 +30,7 @@ jobs:
       - name: Lint
         run: npm run lint
       - name: Test
-        run: npm run test:e2e
+        run: aa-exec --profile=chrome npm run test:e2e
       - name: Build
         run: npm run build
       - name: Release

.husky/commit-msg

@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
 npx commitlint --edit $1

.husky/pre-commit

@@ -1,4 +1 @@
-#!/usr/bin/env sh
-. "$(dirname -- "$0")/_/husky.sh"
-
 npx --no lint-staged

package-lock.json

@@ -20,7 +20,7 @@
     "semantic-release": "semantic-release"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=20"
   },
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -52,8 +52,8 @@
     "typescript": "^5"
   },
   "peerDependencies": {
-    "@nestjs/common": "^9 || ^10 || ^11",
-    "@nestjs/core": "^9 || ^10 | ^11",
+    "@nestjs/common": "^10 || ^11",
+    "@nestjs/core": "^10 | ^11",
     "puppeteer": "^21 || ^22 || ^23",
     "puppeteer-extra": "^3",
     "reflect-metadata": "*",

package.json

@@ -31,7 +31,8 @@ export class BaseController {
 
   @Get('is-incognito')
   async isIncognito(): Promise<boolean> {
-    return this.browser.browserContexts().reduce((acc, context) => acc || context.isIncognito(), true);
+    await this.browser.createBrowserContext();
+    return this.browser.browserContexts().length > 1;
   }
 
   @Get('test-page')