fix(RequestInterface): Revert method overloading with adding some tests #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
added
Type: Bug
gr2m
reviewed
Jun 27, 2022
| : RequestParameters | ||
| ): R extends keyof Endpoints | ||
| ? Promise<Endpoints[R]["response"]> | ||
| : Promise<OctokitResponse<any>>; |
Contributor
There was a problem hiding this comment.
do we still need the overwrite? Shouldn't we combine this with L:26-29 as it was before?
Contributor
Author
This reverts commit b488f9c.
This was referenced Jun 28, 2022
Contributor
|
It's been a while but I think I found some smarter types when I worked on Octokit Next, maybe some of it might be applicable to the current types? Work on Ocotkit Next is stalled, unfortunately https://github.com/octokit/octokit-next.js/blob/main/packages/types/request.d.ts#L30-L91 |
Contributor
|
🎉 This PR is included in version 6.38.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 28, 2022
Contributor
Author
|
Thank you for your reviewing and merging! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have faced CI broken in
Bump @octokit/types from 6.37.0 to 6.37.1ref: https://github.com/kachick/wait-other-jobs/runs/7064440245?check_suite_focus=true.It looks type mismatch with https://github.com/octokit/plugin-paginate-rest.js.
Removing
types.ts/src/RequestInterface.ts
Line 37 in 6e15b56
This PR is just a suggestion to includes the test. (Current test does not use exists tsconfig.json, so vscode is reporting some errors).
@levenleven I have cherry-picked your commit into this PR 🙏