RHAIENG-1439: chore: --ServerApp.tornado_settings removal (#2572)

jstourac · web-flow · commit f1a1578c461b · 2025-10-17T12:10:46.000+02:00
This configuration has been removed from the Dashboard code as we
decided to disable the Log out possibility from workbench. I think we
can remove this option also from this codebase despite it's not
necessary as the presence of this code doesn't affect the production
code.
diff --git a/codeserver/ubi9-python-3.12/test/test_startup.py b/codeserver/ubi9-python-3.12/test/test_startup.py
@@ -39,7 +39,6 @@ def get_notebook_args_configuration(self) -> str:
                 "--ServerApp.password=''",
                 f"--ServerApp.base_url=/notebook/{self.project_name}/{self.notebook_id}",
                 "--ServerApp.quit_button=False",
-                f'--ServerApp.tornado_settings={{"user":"{self.translated_username}","hub_host":"{self.origin}","hub_prefix":"/projects/{self.project_name}"}}',
             ]
         )
         return expected_args
diff --git a/jupyter/datascience/ubi9-python-3.12/kustomize/base/statefulset.yaml b/jupyter/datascience/ubi9-python-3.12/kustomize/base/statefulset.yaml
@@ -28,7 +28,6 @@ spec:
                 --ServerApp.password=''
                 --ServerApp.base_url=/notebook/opendatahub/jovyan
                 --ServerApp.quit_button=False
-                --ServerApp.tornado_settings={"user":"jovyan","hub_host":"https://opendatahub.io","hub_prefix":"/notebookController/jovyan"}
           ports:
             - name: notebook-port
               protocol: TCP
diff --git a/jupyter/minimal/ubi9-python-3.12/kustomize/base/statefulset.yaml b/jupyter/minimal/ubi9-python-3.12/kustomize/base/statefulset.yaml
@@ -28,7 +28,6 @@ spec:
                 --ServerApp.password=''
                 --ServerApp.base_url=/notebook/opendatahub/jovyan
                 --ServerApp.quit_button=False
-                --ServerApp.tornado_settings={"user":"jovyan","hub_host":"https://opendatahub.io","hub_prefix":"/notebookController/jovyan"}
           ports:
             - name: notebook-port
               protocol: TCP
diff --git a/jupyter/pytorch+llmcompressor/ubi9-python-3.12/kustomize/base/statefulset.yaml b/jupyter/pytorch+llmcompressor/ubi9-python-3.12/kustomize/base/statefulset.yaml
@@ -28,7 +28,6 @@ spec:
                 --ServerApp.password=''
                 --ServerApp.base_url=/notebook/opendatahub/jovyan
                 --ServerApp.quit_button=False
-                --ServerApp.tornado_settings={"user":"jovyan","hub_host":"https://opendatahub.io","hub_prefix":"/notebookController/jovyan"}
           ports:
             - name: notebook-port
               protocol: TCP
diff --git a/jupyter/pytorch/ubi9-python-3.12/kustomize/base/statefulset.yaml b/jupyter/pytorch/ubi9-python-3.12/kustomize/base/statefulset.yaml
@@ -28,7 +28,6 @@ spec:
                 --ServerApp.password=''
                 --ServerApp.base_url=/notebook/opendatahub/jovyan
                 --ServerApp.quit_button=False
-                --ServerApp.tornado_settings={"user":"jovyan","hub_host":"https://opendatahub.io","hub_prefix":"/notebookController/jovyan"}
           ports:
             - name: notebook-port
               protocol: TCP
diff --git a/jupyter/rocm/pytorch/ubi9-python-3.12/kustomize/base/statefulset.yaml b/jupyter/rocm/pytorch/ubi9-python-3.12/kustomize/base/statefulset.yaml
@@ -28,7 +28,6 @@ spec:
                 --ServerApp.password=''
                 --ServerApp.base_url=/notebook/opendatahub/jovyan
                 --ServerApp.quit_button=False
-                --ServerApp.tornado_settings={"user":"jovyan","hub_host":"https://opendatahub.io","hub_prefix":"/notebookController/jovyan"}
           ports:
             - name: notebook-port
               protocol: TCP
diff --git a/jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/statefulset.yaml b/jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/statefulset.yaml
@@ -28,7 +28,6 @@ spec:
                 --ServerApp.password=''
                 --ServerApp.base_url=/notebook/opendatahub/jovyan
                 --ServerApp.quit_button=False
-                --ServerApp.tornado_settings={"user":"jovyan","hub_host":"https://opendatahub.io","hub_prefix":"/notebookController/jovyan"}
           ports:
             - name: notebook-port
               protocol: TCP
diff --git a/jupyter/tensorflow/ubi9-python-3.12/kustomize/base/statefulset.yaml b/jupyter/tensorflow/ubi9-python-3.12/kustomize/base/statefulset.yaml
@@ -28,7 +28,6 @@ spec:
                 --ServerApp.password=''
                 --ServerApp.base_url=/notebook/opendatahub/jovyan
                 --ServerApp.quit_button=False
-                --ServerApp.tornado_settings={"user":"jovyan","hub_host":"https://opendatahub.io","hub_prefix":"/notebookController/jovyan"}
           ports:
             - name: notebook-port
               protocol: TCP
diff --git a/jupyter/trustyai/ubi9-python-3.12/kustomize/base/statefulset.yaml b/jupyter/trustyai/ubi9-python-3.12/kustomize/base/statefulset.yaml
@@ -28,7 +28,6 @@ spec:
                 --ServerApp.password=''
                 --ServerApp.base_url=/notebook/opendatahub/jovyan
                 --ServerApp.quit_button=False
-                --ServerApp.tornado_settings={"user":"jovyan","hub_host":"https://opendatahub.io","hub_prefix":"/notebookController/jovyan"}
           ports:
             - name: notebook-port
               protocol: TCP
diff --git a/tests/containers/workbenches/jupyterlab/jupyterlab_test.py b/tests/containers/workbenches/jupyterlab/jupyterlab_test.py
@@ -36,7 +36,6 @@ def test_spinner_html_loaded(self, jupyterlab_image: conftest.Image) -> None:
                     "--ServerApp.password=''",
                     "--ServerApp.base_url=/notebook/opendatahub/jovyan",
                     "--ServerApp.quit_button=False",
-                    """--ServerApp.tornado_settings={"user":"jovyan","hub_host":"https://opendatahub.io","hub_prefix":"/notebookController/jovyan"}""",
                 ]
             ),
         )

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ def get_notebook_args_configuration(self) -> str:`
`39`	`39`	`"--ServerApp.password=''",`
`40`	`40`	`f"--ServerApp.base_url=/notebook/{self.project_name}/{self.notebook_id}",`
`41`	`41`	`"--ServerApp.quit_button=False",`
`42`		`- f'--ServerApp.tornado_settings={{"user":"{self.translated_username}","hub_host":"{self.origin}","hub_prefix":"/projects/{self.project_name}"}}',`
`43`	`42`	`]`
`44`	`43`	`)`
`45`	`44`	`return expected_args`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,6 @@ def test_spinner_html_loaded(self, jupyterlab_image: conftest.Image) -> None:`
`36`	`36`	`"--ServerApp.password=''",`
`37`	`37`	`"--ServerApp.base_url=/notebook/opendatahub/jovyan",`
`38`	`38`	`"--ServerApp.quit_button=False",`
`39`		`- """--ServerApp.tornado_settings={"user":"jovyan","hub_host":"https://opendatahub.io","hub_prefix":"/notebookController/jovyan"}""",`
`40`	`39`	`]`
`41`	`40`	`),`
`42`	`41`	`)`