-
Notifications
You must be signed in to change notification settings - Fork 124
Open
Description
Context
In PR #2690, a helper script was added to generate the list of additional packages by comparing SCL and AIPCC package lists. The current implementation uses rsplit('-', 2)[0] to strip version information, which can be inaccurate for package names containing dashes.
Current Approach
line.strip().rsplit('-', 2)[0]This can leave version-like suffixes when package names contain dashes (e.g., httpd-core-2.4.0-... becomes httpd-core-2.4.0).
Suggested Improvement
Use RPM's query format to get pure package names directly:
podman run --rm --pull=always quay.io/sclorg/python-312-c9s:c9s rpm -qa --qf '%{NAME}\n' | sort > /tmp/scl_packages.txt
podman run --rm --pull=always quay.io/aipcc/base-images/cpu:3.1 rpm -qa --qf '%{NAME}\n' | sort > /tmp/aipcc_packages.txtAnd simplify the Python helper to read raw names without rsplit.
Benefits
- Package diffs will be based purely on package presence, independent of version components
- More reliable and maintainable approach
- Future updates will be cleaner
References
- PR: RHAIENG-2042: chore(base-images): use AIPCC-style scripting instead of scl base to add
s390xarchitecture to odh-base-image-cpu-py312-c9s #2690 - Comment: RHAIENG-2042: chore(base-images): use AIPCC-style scripting instead of scl base to add
s390xarchitecture to odh-base-image-cpu-py312-c9s #2690 (comment) - Requested by: @jiridanek
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
📋 Backlog