Skip to content
This repository was archived by the owner on Feb 5, 2022. It is now read-only.

Commit 956e241

Browse files
committed
fix(opportunities): fix feedback from pr
1 parent 6e585eb commit 956e241

File tree

5 files changed

+273
-183
lines changed

5 files changed

+273
-183
lines changed

src/assets/i18n/en.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,9 @@ export const translations = {
129129
fullName: 'Full Name*',
130130
company: 'Company',
131131
email: 'E-mail*',
132-
phone: 'Phone',
133-
github: 'GitHub URL',
132+
phone: 'Phone*',
133+
github: 'GitHub URL*',
134+
designProfile: 'Link to your profile*',
134135
whatAreYouWorkingOn: 'What are you working on?',
135136
appDevelopment: 'App Development',
136137
webDevelopment: 'Web Development',
@@ -156,6 +157,9 @@ export const translations = {
156157
email: 'example@gmail.com',
157158
phone: 'Your Phone Number',
158159
message: 'Briefly describe your project',
160+
fullName: 'Your Name Here',
161+
github: 'Your Github account',
162+
designProfile: 'Your profile account',
159163
},
160164
},
161165
},
@@ -415,10 +419,11 @@ export const translations = {
415419
resume: 'Resume/CV',
416420
unique: {
417421
title: 'What makes you unique?',
418-
text: 'In 150 characters or fewer, tell us what makes you unique. Try to be creative and say something that will catch our eye!',
422+
text: 'In 200 characters or less, tell us what makes you unique.',
419423
},
420424
submit: 'Submit Application',
421-
submitted: 'Application Submitted',
425+
submitted: 'Application Submitted!',
426+
thanks_interest: 'Thank you for your interest in OpenForge.',
422427
thanks: {
423428
title: 'Thank you!',
424429
text: 'If your resume is a match, someone will be in touch to deliver the necessary materials to complete the challenge.',

src/components/content-graphic/content-graphic.scss

Lines changed: 43 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
}
88

99
app-img {
10+
@include media-breakpoint-down(sm) {
11+
order: 2;
12+
}
13+
1014
img {
1115
max-height: 400px;
1216
@include media-breakpoint-down(sm) {
@@ -34,6 +38,16 @@
3438
&.thin {
3539
font-weight: 400;
3640
}
41+
42+
&.margin-bottom {
43+
margin-bottom: 2rem;
44+
@include media-breakpoint-down(lg) {
45+
margin-bottom: 1rem;
46+
}
47+
@include media-breakpoint-down(sm) {
48+
margin-bottom: 0;
49+
}
50+
}
3751
}
3852

3953
p {
@@ -51,12 +65,39 @@
5165
}
5266
}
5367

54-
.align-left {
55-
text-align: left !important;
68+
li {
69+
@include media-breakpoint-down(sm) {
70+
text-align: left;
71+
}
72+
}
73+
74+
.auto-align {
75+
text-align: left;
76+
77+
@include media-breakpoint-down(md) {
78+
text-align: right;
79+
}
80+
81+
@include media-breakpoint-down(sm) {
82+
text-align: center;
83+
}
5684
}
5785

5886
.footer-btn {
5987
display: flex;
6088
justify-content: flex-start;
89+
margin-top: 2rem;
90+
91+
@include media-breakpoint-down(sm) {
92+
margin-bottom: 2rem;
93+
margin-top: 0;
94+
}
95+
}
96+
97+
.content-container {
98+
@include media-breakpoint-down(sm) {
99+
display: flex;
100+
flex-direction: column;
101+
}
61102
}
62103
}

src/components/content-graphic/content-graphic.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ export class ContentGraphic {
99
@Prop() reverse: boolean = false;
1010
@Prop() preLoadImg: boolean = false;
1111
@Prop() alt: string;
12+
@Prop() wider: boolean;
13+
@Prop() inverseOrder: boolean;
1214

1315
render() {
1416
return (
@@ -23,6 +25,7 @@ export class ContentGraphic {
2325
>
2426
<div
2527
class={{
28+
'col-lg-4': this.wider,
2629
'col-sm-12': true,
2730
'col-md-5': true,
2831
'px-lg-5': true,
@@ -34,10 +37,12 @@ export class ContentGraphic {
3437
</div>
3538
<div
3639
class={{
40+
'col-lg-6': this.wider,
3741
'col-sm-12': true,
3842
'col-md-5': true,
39-
'px-lg-5': true,
43+
'px-lg-5': !this.wider,
4044
'text-md-right': this.reverse,
45+
'content-container': this.inverseOrder,
4146
}}
4247
>
4348
<slot name="header" />

src/pages/app-opportunities/app-opportunities.scss

Lines changed: 39 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
background-size: contain;
55
background-repeat: no-repeat;
66
height: calc(100vh - 76px);
7-
margin-top: 76px;
7+
padding-top: 76px;
88

99
&.header-animated {
1010
background-image: url('/assets/opportunities/opportunities-header-animated.svg');
@@ -338,19 +338,39 @@
338338
letter-spacing: 0.1rem;
339339
line-height: 1.4rem;
340340
margin-bottom: 0;
341-
width: 20%;
342-
@include media-breakpoint-down(sm) {
343-
width: 100%;
341+
width: 100%;
342+
343+
&.resume {
344+
width: initial;
345+
}
346+
347+
&.resume-filename {
348+
width: initial;
349+
margin-left: 16px;
350+
}
351+
352+
&.resume-btn {
353+
background-color: #0095aa;
354+
border: 0.75px solid #ffffff;
355+
border-radius: 16px;
356+
-webkit-box-shadow: 0 2px 4px 0 rgba(128, 128, 128, 0.5);
357+
box-shadow: 0 2px 4px 0 rgba(128, 128, 128, 0.5);
358+
width: initial;
359+
padding: 5px 10px;
360+
text-align: center;
361+
color: white;
362+
margin-left: 16px;
344363
}
345364
}
346365

347-
.form-control,
348-
input[type='file'] {
366+
.form-control {
349367
display: inline-block;
350-
width: 80%;
351-
@include media-breakpoint-down(sm) {
352-
width: 100%;
353-
}
368+
width: 100%;
369+
}
370+
371+
input[type='file'] {
372+
visibility: hidden;
373+
display: none;
354374
}
355375
}
356376
.error {
@@ -382,4 +402,13 @@
382402
margin: 0;
383403
border: 1.5px solid rgba(23, 23, 25, 0.1);
384404
}
405+
406+
.submitted-text {
407+
margin-top: 2rem;
408+
409+
p {
410+
margin-bottom: 0;
411+
text-align: center;
412+
}
413+
}
385414
}

0 commit comments

Comments
 (0)