fix: AWS ApiGW v1 (REST) converter incorrectly parses all query parameters as arrays #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15e773f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying a NextJS application using OpenNext in AWS Api Gateway v1 (REST), the image optimizer function breaks.
APIGWv1 event payload always includes the incoming query strings in both the
multiValueQueryStringParameterandqueryStringParametersattributes, even if they are single valued.The converter was parsing all the incoming query parameters as arrays, even if they were single valued. This makes functions like the Image Optimizer to fail as it does not support array parameters. Also, it breaks functions that expect single valued query parameters that were working just fine with OpenNext v2.
This PR fixes the converter, parsing single valued query parameters as strings, and multi valued ones as arrays.