fix: prevent nil pointer panic in EventEmitter

Add nil check for Kubernetes client in EmitMessage to prevent panic when
client is uninitialized. This fixes a crash that occurs during error
handling in GitLab provider when 401 errors are encountered.

The EventEmitter now gracefully handles three nil scenarios:
- nil repo: skips event creation, continues logging
- nil logger: skips logging, continues event creation
- nil client: skips event creation, continues logging

Added comprehensive test coverage for nil client scenario to match
existing tests for nil repo and nil logger cases.

Fixes crash: runtime error: invalid memory address or nil pointer
dereference at pkg/events/emit.go:36

Jira: https://issues.redhat.com/browse/SRVKP-8910
Assisted-by: Claude-Sonnet-4.5 (via Claude Code)
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

Author: chmouel

pkg/events/emit.go

@@ -31,7 +31,7 @@ func (e *EventEmitter) SetLogger(logger *zap.SugaredLogger) {
 }
 
 func (e *EventEmitter) EmitMessage(repo *v1alpha1.Repository, loggerLevel zapcore.Level, reason, message string) {
-	if repo != nil {
+	if repo != nil && e.client != nil {
 		event := makeEvent(repo, loggerLevel, reason, message)
 		if _, err := e.client.CoreV1().Events(event.Namespace).Create(context.Background(), event, metav1.CreateOptions{}); err != nil {
 			if e.logger != nil {

pkg/events/emit_test.go

@@ -13,6 +13,7 @@ import (
 	"gotest.tools/v3/assert"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/client-go/kubernetes"
 	rtesting "knative.dev/pkg/reconciler/testing"
 )
 
@@ -28,6 +29,7 @@ func TestEventEmitter_EmitMessage(t *testing.T) {
 		expectEvent  bool
 		expectedType string
 		useNilLogger bool
+		useNilClient bool
 	}{
 		{
 			name: "repo exists",
@@ -82,6 +84,21 @@ func TestEventEmitter_EmitMessage(t *testing.T) {
 			expectedType: v1.EventTypeWarning,
 			useNilLogger: true,
 		},
+		{
+			name: "nil client doesn't cause panic",
+			repo: &v1alpha1.Repository{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "test-repo",
+					Namespace: "test-ns",
+				},
+				Spec: v1alpha1.RepositorySpec{},
+			},
+			message:      "info-message",
+			logLevel:     zap.InfoLevel,
+			expectEvent:  false,
+			expectedType: v1.EventTypeNormal,
+			useNilClient: true,
+		},
 	}
 
 	for _, tt := range tests {
@@ -97,8 +114,16 @@ func TestEventEmitter_EmitMessage(t *testing.T) {
 				logger = fakelogger
 			}
 
-			// emit event - this should not panic even with nil logger
-			NewEventEmitter(stdata.Kube, logger).EmitMessage(tt.repo, tt.logLevel, tt.reason, tt.message)
+			// Use nil client for specific test case
+			var client kubernetes.Interface
+			if tt.useNilClient {
+				client = nil
+			} else {
+				client = stdata.Kube
+			}
+
+			// emit event - this should not panic even with nil logger or nil client
+			NewEventEmitter(client, logger).EmitMessage(tt.repo, tt.logLevel, tt.reason, tt.message)
 
 			if tt.expectEvent {
 				events, err := stdata.Kube.CoreV1().Events(tt.repo.Namespace).List(context.Background(), metav1.ListOptions{})