chore: add test

Signed-off-by: Chris Laprun <metacosm@gmail.com>

Author: metacosm

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResourceTest.java

@@ -21,6 +21,7 @@
 import org.junit.jupiter.api.Test;
 
 import io.fabric8.kubernetes.api.model.ConfigMap;
+import io.fabric8.kubernetes.api.model.ConfigMapBuilder;
 import io.fabric8.kubernetes.api.model.ObjectMetaBuilder;
 import io.javaoperatorsdk.operator.api.reconciler.Context;
 import io.javaoperatorsdk.operator.api.reconciler.DefaultContext;
@@ -33,8 +34,11 @@
 class AbstractDependentResourceTest {
 
   private static final TestCustomResource PRIMARY = new TestCustomResource();
-  private static final DefaultContext<TestCustomResource> CONTEXT =
-      new DefaultContext<>(mock(), mock(), PRIMARY, false, false);
+  private static final DefaultContext<TestCustomResource> CONTEXT = createContext(PRIMARY);
+
+  private static DefaultContext<TestCustomResource> createContext(TestCustomResource primary) {
+    return new DefaultContext<>(mock(), mock(), primary, false, false);
+  }
 
   @Test
   void throwsExceptionIfDesiredIsNullOnCreate() {
@@ -76,6 +80,27 @@ void throwsExceptionIfUpdateReturnsNull() {
         DependentResourceException.class, () -> testDependentResource.reconcile(PRIMARY, CONTEXT));
   }
 
+  @Test
+  void checkThatDesiredIsOnlyCalledOnce() {
+    final var testDependentResource = new DesiredCallCountCheckingDR();
+    final var primary = new TestCustomResource();
+    final var spec = primary.getSpec();
+    spec.setConfigMapName("foo");
+    spec.setKey("key");
+    spec.setValue("value");
+    final var context = createContext(primary);
+    testDependentResource.reconcile(primary, context);
+
+    spec.setValue("value2");
+    testDependentResource.reconcile(primary, context);
+
+    assertEquals(1, testDependentResource.desiredCallCount);
+
+    context.getOrComputeDesiredStateFor(
+        testDependentResource, p -> testDependentResource.desired(p, context));
+    assertEquals(1, testDependentResource.desiredCallCount);
+  }
+
   private ConfigMap configMap() {
     ConfigMap configMap = new ConfigMap();
     configMap.setMetadata(
@@ -131,22 +156,12 @@ protected ConfigMap desired(TestCustomResource primary, Context<TestCustomResour
       return desired;
     }
 
-    public ConfigMap getSecondary() {
-      return secondary;
-    }
-
-    public TestDependentResource setSecondary(ConfigMap secondary) {
+    public void setSecondary(ConfigMap secondary) {
       this.secondary = secondary;
-      return this;
-    }
-
-    public ConfigMap getDesired() {
-      return desired;
     }
 
-    public TestDependentResource setDesired(ConfigMap desired) {
+    public void setDesired(ConfigMap desired) {
       this.desired = desired;
-      return this;
     }
 
     @Override
@@ -173,4 +188,35 @@ public Matcher.Result<ConfigMap> match(
       return result;
     }
   }
+
+  private static class DesiredCallCountCheckingDR extends TestDependentResource {
+    private short desiredCallCount;
+
+    @Override
+    public ConfigMap update(
+        ConfigMap actual,
+        ConfigMap desired,
+        TestCustomResource primary,
+        Context<TestCustomResource> context) {
+      return desired;
+    }
+
+    @Override
+    public ConfigMap create(
+        ConfigMap desired, TestCustomResource primary, Context<TestCustomResource> context) {
+      return desired;
+    }
+
+    @Override
+    protected ConfigMap desired(TestCustomResource primary, Context<TestCustomResource> context) {
+      final var spec = primary.getSpec();
+      desiredCallCount++;
+      return new ConfigMapBuilder()
+          .editOrNewMetadata()
+          .withName(spec.getConfigMapName())
+          .endMetadata()
+          .addToData(spec.getKey(), spec.getValue())
+          .build();
+    }
+  }
 }