fix: only load Version from properties once (#1886)

* fix: only load Version from properties once

* fix: format

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java

@@ -53,7 +53,7 @@ public BaseConfigurationService(Version version, Cloner cloner) {
   }
 
   public BaseConfigurationService() {
-    this(Utils.loadFromProperties());
+    this(Utils.VERSION);
   }
 
   @Override

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java

@@ -70,6 +70,6 @@ public synchronized static void reset() {
   }
 
   static ConfigurationService createDefault() {
-    return new BaseConfigurationService(Utils.loadFromProperties());
+    return new BaseConfigurationService(Utils.VERSION);
   }
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Utils.java

@@ -27,12 +27,17 @@ public class Utils {
   public static final String GENERIC_PARAMETER_TYPE_ERROR_PREFIX =
       "Couldn't retrieve generic parameter type from ";
 
+  public static final Version VERSION = loadFromProperties();
+
   /**
    * Attempts to load version information from a properties file produced at build time, currently
    * via the {@code git-commit-id-plugin} maven plugin.
    *
    * @return a {@link Version} object encapsulating the version information
+   * @deprecated use {@link #VERSION} instead, as this method will be made internal in a future
+   *             release
    */
+  @Deprecated
   public static Version loadFromProperties() {
     final var is =
         Thread.currentThread().getContextClassLoader().getResourceAsStream("version.properties");

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/VersionTest.java

@@ -8,7 +8,7 @@ class VersionTest {
 
   @Test
   void versionShouldReturnTheSameResultFromMavenAndProperties() {
-    String versionFromProperties = Utils.loadFromProperties().getSdkVersion();
+    String versionFromProperties = Utils.VERSION.getSdkVersion();
     String versionFromMaven = Version.UNKNOWN.getSdkVersion();
 
     assertEquals(versionFromProperties, versionFromMaven);