Implement comments

Author: esrakartalOpt

lib/optimizely/cmab/cmab_client.rb

@@ -161,7 +161,7 @@ def _do_fetch_with_retry(url, request_body, retry_config, timeout)
           Kernel.sleep(backoff)
 
           backoff = [
-            backoff * (retry_config.backoff_multiplier**(attempt + 1)),
+            backoff * retry_config.backoff_multiplier,
             retry_config.max_backoff
           ].min
         else

spec/cmab_client_spec.rb

@@ -70,7 +70,7 @@
       expect(Kernel).not_to have_received(:sleep)
     end
 
-    it 'should return HTTP exception' do
+    it 'should raise error on http client exception' do
       WebMock.stub_request(:post, expected_url)
              .with(body: expected_body_for_webmock, headers: expected_headers)
              .to_raise(StandardError.new('Connection error'))
@@ -85,7 +85,7 @@
       expect(Kernel).not_to have_received(:sleep)
     end
 
-    it 'should not return 200 status' do
+    it 'should raise error on non success status' do
       WebMock.stub_request(:post, expected_url)
              .with(body: expected_body_for_webmock, headers: expected_headers)
              .to_return(status: 500)
@@ -115,7 +115,7 @@
       expect(Kernel).not_to have_received(:sleep)
     end
 
-    it 'should return invalid response structure' do
+    it 'should raise error on invalid structure' do
       WebMock.stub_request(:post, expected_url)
              .with(body: expected_body_for_webmock, headers: expected_headers)
              .to_return(status: 200, body: {'no_predictions' => []}.to_json, headers: {'Content-Type' => 'application/json'})