Skip to content

Commit 76bb263

Browse files
committed
Add compile step data to bench results.
1 parent 1d34199 commit 76bb263

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

common.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"Jsonnet files should not include this file directly but use ci/common.jsonnet instead."
55
],
66

7-
"mx_version": "7.64.2",
7+
"mx_version": "7.65.3",
88

99
"COMMENT.jdks": "When adding or removing JDKs keep in sync with JDKs in ci/common.jsonnet",
1010
"jdks": {

sdk/mx.sdk/mx_sdk_benchmark.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1523,15 +1523,18 @@ def image_build_statistics_rules(self, benchmarks):
15231523
return rules
15241524

15251525
def image_build_timers_rules(self, benchmarks):
1526-
measured_phases = ['total', 'setup', 'classlist', 'analysis', 'universe', 'compile', 'layout',
1526+
measured_phases = ['total', 'setup', 'classlist', 'analysis', 'universe', 'compile', '(compile)', 'layout',
15271527
'image', 'write']
1528+
metric_object_mapper = {'(compile)': 'compile-step'}
1529+
15281530
if not self.pgo_use_perf:
15291531
# No debug info with perf, [GR-66850]
15301532
measured_phases.append('dbginfo')
15311533
rules = []
15321534
for i in range(0, len(measured_phases)):
15331535
phase = measured_phases[i]
15341536
value_name = phase + "_time"
1537+
metric_object = metric_object_mapper.get(phase, phase)
15351538
rules += self._get_image_build_stats_rules({
15361539
"bench-suite": self.config.benchmark_suite_name,
15371540
"benchmark": benchmarks[0],
@@ -1542,7 +1545,7 @@ def image_build_timers_rules(self, benchmarks):
15421545
"metric.score-function": "id",
15431546
"metric.better": "lower",
15441547
"metric.iteration": 0,
1545-
"metric.object": phase,
1548+
"metric.object": metric_object,
15461549
}, [value_name])
15471550
value_name = phase + "_memory"
15481551
rules += self._get_image_build_stats_rules({
@@ -1555,7 +1558,7 @@ def image_build_timers_rules(self, benchmarks):
15551558
"metric.score-function": "id",
15561559
"metric.better": "lower",
15571560
"metric.iteration": 0,
1558-
"metric.object": phase + "_memory",
1561+
"metric.object": metric_object + "_memory",
15591562
}, [value_name])
15601563
return rules
15611564

0 commit comments

Comments
 (0)