[GR-68157] Do not use CompilerDirectives.shouldNotReachHere before Truffle runtime is created.

PullRequest: graal/21769

Author: tzezula

truffle/src/com.oracle.truffle.api/src/com/oracle/truffle/api/InternalResource.java

@@ -400,7 +400,7 @@ private void copyResource(Path source, Path target, Set<PosixFilePermission> att
             String resourceName = getResourceName(source);
             Path parent = target.getParent();
             if (parent == null) {
-                throw CompilerDirectives.shouldNotReachHere("RelativeResourcePath must be non-empty.");
+                throw new AssertionError("RelativeResourcePath must be non-empty.");
             }
             Files.createDirectories(parent);
             try (BufferedInputStream in = new BufferedInputStream(getResourceStream(resourceName))) {
@@ -546,7 +546,7 @@ public String toString() {
         public static OS getCurrent() {
             String os = System.getProperty("os.name");
             if (os == null) {
-                throw CompilerDirectives.shouldNotReachHere("The 'os.name' system property is not set.");
+                throw new AssertionError("The 'os.name' system property is not set.");
             } else if (os.equalsIgnoreCase("linux")) {
                 return LINUX;
             } else if (os.equalsIgnoreCase("mac os x") || os.equalsIgnoreCase("darwin")) {
@@ -620,7 +620,7 @@ public String toString() {
         public static CPUArchitecture getCurrent() {
             String arch = System.getProperty("os.arch");
             if (arch == null) {
-                throw CompilerDirectives.shouldNotReachHere("The 'os.arch' system property is not set.");
+                throw new AssertionError("The 'os.arch' system property is not set.");
             }
             return switch (arch) {
                 case "amd64", "x86_64" -> AMD64;

truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/InternalResourceCache.java

@@ -81,7 +81,6 @@
 import org.graalvm.nativeimage.c.function.CEntryPointLiteral;
 import org.graalvm.nativeimage.c.function.CFunctionPointer;
 
-import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.InternalResource;
 import com.oracle.truffle.api.TruffleOptions;
 import com.oracle.truffle.api.provider.InternalResourceProvider;
@@ -176,7 +175,7 @@ void initializeOwningRoot(InternalResourceRoots.Root root) {
                 case RESOURCE -> InternalResourceRoots.overriddenResourceRootProperty(id, resourceId) + " system property";
                 case COMPONENT -> InternalResourceRoots.overriddenComponentRootProperty(id) + " system property";
                 case UNVERSIONED -> "internal resource cache root directory";
-                default -> throw CompilerDirectives.shouldNotReachHere(root.kind().name());
+                default -> throw new AssertionError(root.kind().name());
             };
             InternalResourceRoots.logInternalResourceEvent("Resolved a pre-created directory for the internal resource %s::%s to: %s, determined by the %s with the value %s.",
                             id, resourceId, path, hint, root.path());
@@ -231,7 +230,7 @@ private static InternalResource.Env createInternalResourceEnvReflectively(Intern
             newEnv.setAccessible(true);
             return newEnv.newInstance(resource, (BooleanSupplier) () -> TruffleOptions.AOT);
         } catch (ReflectiveOperationException e) {
-            throw CompilerDirectives.shouldNotReachHere(e);
+            throw new AssertionError("Failed to instantiate InternalResource.Env", e);
         }
     }
 
@@ -252,7 +251,7 @@ private Path installResource(Function<InternalResource, InternalResource.Env> re
             InternalResourceRoots.logInternalResourceEvent("Resolved a directory for the internal resource %s::%s to: %s, unpacking resource files.", id, resourceId, target);
             Path parent = target.getParent();
             if (parent == null) {
-                throw CompilerDirectives.shouldNotReachHere("Target must have a parent directory but was " + target);
+                throw new AssertionError("Target must have a parent directory but was " + target);
             }
             Path owner = Files.createDirectories(Objects.requireNonNull(parent));
             Path tmpDir = Files.createTempDirectory(owner, null);

truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/InternalResourceRoots.java

@@ -58,7 +58,6 @@
 import org.graalvm.nativeimage.ImageInfo;
 import org.graalvm.nativeimage.ProcessProperties;
 
-import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.InternalResource;
 import com.oracle.truffle.api.TruffleOptions;
 
@@ -298,7 +297,7 @@ private static Path getExecutablePath() {
         } else if (ImageInfo.isSharedLibrary()) {
             path = ProcessProperties.getObjectFile(InternalResourceCacheSymbol.SYMBOL);
         } else {
-            throw CompilerDirectives.shouldNotReachHere("Should only be invoked within native image runtime code.");
+            throw new AssertionError("Should only be invoked within native image runtime code.");
         }
         return path == null ? null : Path.of(path);
     }
@@ -311,7 +310,7 @@ private static ResolvedCacheFolder findCacheRootDefault() {
         }
         String userHomeValue = System.getProperty("user.home");
         if (userHomeValue == null) {
-            throw CompilerDirectives.shouldNotReachHere("The 'user.home' system property is not set.");
+            throw new AssertionError("The 'user.home' system property is not set.");
         }
         Path userHome = Paths.get(userHomeValue);
         ResolvedCacheFolder container = switch (InternalResource.OS.getCurrent()) {