made DumpPathTest a subprocess test

Author: dougxc

compiler/src/jdk.graal.compiler.test/src/jdk/graal/compiler/core/test/DumpPathTest.java

@@ -31,10 +31,10 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import jdk.graal.compiler.core.GraalCompilerOptions;
 import org.graalvm.collections.EconomicMap;
 import org.junit.Test;
 
+import jdk.graal.compiler.core.GraalCompilerOptions;
 import jdk.graal.compiler.debug.DebugOptions;
 import jdk.graal.compiler.debug.DebugOptions.PrintGraphTarget;
 import jdk.graal.compiler.debug.TTY;
@@ -45,46 +45,61 @@
  * Check that setting the dump path results in files ending up in the right directory with matching
  * names.
  */
-public class DumpPathTest extends GraalCompilerTest {
+public class DumpPathTest extends SubprocessTest {
+
+    /**
+     * If this test does not complete in 60 seconds, something is very wrong.
+     */
+    private static final int TIME_LIMIT = 60000;
 
     public static Object snippet() {
         return new String("snippet");
     }
 
     @Test
-    public void testDump() throws Exception {
+    public void test() throws IOException, InterruptedException {
+        launchSubprocess(this::runInSubprocess, "-Xmx50M");
+
+    }
+
+    public void runInSubprocess() {
         assumeManagementLibraryIsLoadable();
-        try (TemporaryDirectory temp = new TemporaryDirectory("DumpPathTest")) {
-            String[] extensions = {".cfg", ".bgv", ".graph-strings"};
-            EconomicMap<OptionKey<?>, Object> overrides = OptionValues.newOptionMap();
-            overrides.put(DebugOptions.DumpPath, temp.toString());
-            overrides.put(DebugOptions.ShowDumpFiles, false);
-            overrides.put(DebugOptions.PrintBackendCFG, true);
-            overrides.put(DebugOptions.PrintGraph, PrintGraphTarget.File);
-            overrides.put(DebugOptions.PrintCanonicalGraphStrings, true);
-            overrides.put(DebugOptions.Dump, "*");
-            overrides.put(GraalCompilerOptions.DumpHeapAfter, "<compilation>:Schedule");
-            overrides.put(DebugOptions.MethodFilter, null);
+        try (var _ = new TTY.Filter();
+                        TimeLimit _ = TimeLimit.create(TIME_LIMIT, "DumpPathTest")) {
+            try (TemporaryDirectory temp = new TemporaryDirectory("DumpPathTest")) {
+                String[] extensions = {".cfg", ".bgv", ".graph-strings"};
+                EconomicMap<OptionKey<?>, Object> overrides = OptionValues.newOptionMap();
+                overrides.put(DebugOptions.DumpPath, temp.toString());
+                overrides.put(DebugOptions.ShowDumpFiles, false);
+                overrides.put(DebugOptions.PrintBackendCFG, true);
+                overrides.put(DebugOptions.PrintGraph, PrintGraphTarget.File);
+                overrides.put(DebugOptions.PrintCanonicalGraphStrings, true);
+                overrides.put(DebugOptions.Dump, "*");
+                overrides.put(GraalCompilerOptions.DumpHeapAfter, "<compilation>:Schedule");
+                overrides.put(DebugOptions.MethodFilter, null);
 
-            try (AutoCloseable _ = new TTY.Filter()) {
-                // Generate dump files.
-                test(new OptionValues(getInitialOptions(), overrides), "snippet");
-            }
-            // Check that IGV files got created, in the right place.
-            List<Path> paths = checkForFiles(temp.path, extensions);
-            List<Path> compilationHeapDumps = new ArrayList<>();
-            List<Path> phaseHeapDumps = new ArrayList<>();
-            for (Path path : paths) {
-                String name = path.toString();
-                if (name.endsWith(".compilation.hprof")) {
-                    compilationHeapDumps.add(path);
-                } else if (name.endsWith(".hprof")) {
-                    phaseHeapDumps.add(path);
+                try (var _ = new TTY.Filter()) {
+                    // Generate dump files.
+                    test(new OptionValues(getInitialOptions(), overrides), "snippet");
+                }
+                // Check that IGV files got created, in the right place.
+                List<Path> paths = checkForFiles(temp.path, extensions);
+                List<Path> compilationHeapDumps = new ArrayList<>();
+                List<Path> phaseHeapDumps = new ArrayList<>();
+                for (Path path : paths) {
+                    String name = path.toString();
+                    if (name.endsWith(".compilation.hprof")) {
+                        compilationHeapDumps.add(path);
+                    } else if (name.endsWith(".hprof")) {
+                        phaseHeapDumps.add(path);
+                    }
                 }
-            }
 
-            assertTrue(!compilationHeapDumps.isEmpty());
-            assertTrue(!phaseHeapDumps.isEmpty());
+                assertTrue(!compilationHeapDumps.isEmpty());
+                assertTrue(!phaseHeapDumps.isEmpty());
+            }
+        } catch (IOException e) {
+            throw new AssertionError(e);
         }
     }
 
@@ -99,6 +114,7 @@ private static List<Path> checkForFiles(Path directoryPath, String[] extensions)
             for (Path filePath : stream) {
                 result.add(filePath);
                 String fileName = filePath.getFileName().toString();
+                System.out.printf("%s -> %,d bytes%n", filePath, Files.size(filePath));
                 for (int i = 0; i < extensions.length; i++) {
                     String extension = extensions[i];
                     if (fileName.endsWith(extensions[i])) {