Fixed bug when using a "select * from table" query and columns are added

to the table (#125).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -20,6 +20,9 @@ Thin Mode Changes
     (`issue 119 <https://github.com/oracle/python-oracledb/issues/119>`__).
 #)  Fixed bug when getting a record type based on a table (%ROWTYPE)
     (`issue 123 <https://github.com/oracle/python-oracledb/issues/123>`__).
+#)  Fixed bug when using a `select * from table` query and columns are added to
+    the table
+    (`issue 125 <https://github.com/oracle/python-oracledb/issues/125>`__).
 
 Thick Mode Changes
 ++++++++++++++++++

src/oracledb/impl/thin/messages.pyx

@@ -716,7 +716,8 @@ cdef class MessageWithData(Message):
         conn = self.cursor.connection
         for i in range(cursor_impl._num_columns):
             fetch_info = self._process_column_info(buf, cursor_impl)
-            if prev_fetch_var_impls is not None:
+            if prev_fetch_var_impls is not None \
+                    and i < len(prev_fetch_var_impls):
                 self._adjust_fetch_info(prev_fetch_var_impls[i], fetch_info)
             cursor_impl._create_fetch_var(conn, self.cursor, type_handler, i,
                                           fetch_info)

tests/test_4300_cursor_other.py

@@ -1,5 +1,5 @@
 #------------------------------------------------------------------------------
-# Copyright (c) 2020, 2022, Oracle and/or its affiliates.
+# Copyright (c) 2020, 2023, Oracle and/or its affiliates.
 #
 # This software is dual-licensed to you under the Universal Permissive License
 # (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl and Apache License
@@ -826,5 +826,24 @@ def test_4364_binds_between_comment_blocks(self):
                 from dual""")
         self.assertEqual(self.cursor.bindnames(), ["A", "B"])
 
+    def test_4365_add_column_to_cached_query(self):
+        "4365 - test addition of column to cached query"
+        table_name = "test_4365"
+        try:
+            self.cursor.execute(f"drop table {table_name}")
+        except:
+            pass
+        data = ('val 1', 'val 2')
+        self.cursor.execute(f"create table {table_name} (col1 varchar2(10))")
+        self.cursor.execute(f"insert into {table_name} values (:1)", [data[0]])
+        self.connection.commit()
+        self.cursor.execute(f"select * from {table_name}")
+        self.assertEqual(self.cursor.fetchall(), [(data[0],)])
+        self.cursor.execute(f"alter table {table_name} add col2 varchar2(10)")
+        self.cursor.execute(f"update {table_name} set col2 = :1", [data[1]])
+        self.connection.commit()
+        self.cursor.execute(f"select * from {table_name}")
+        self.assertEqual(self.cursor.fetchall(), [data])
+
 if __name__ == "__main__":
     test_env.run_test_cases()