Fixed bug resulting in an inability to connect to 23ai databases which

have fast authentication disabled.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -20,6 +20,8 @@ Thin Mode Changes
 #)  Fixed bug resulting in a segfault when a closed cursor is bound as a REF
     CURSOR
     (`issue 368 <https://github.com/oracle/python-oracledb/issues/368>`__).
+#)  Fixed bug resulting in an inability to connect to 23ai databases which have
+    fast authentication disabled.
 
 Thick Mode Changes
 ++++++++++++++++++

src/oracledb/impl/thin/capabilities.pyx

@@ -69,10 +69,6 @@ cdef class Capabilities:
         if server_caps[TNS_CCAP_FIELD_VERSION] < self.ttc_field_version:
             self.ttc_field_version = server_caps[TNS_CCAP_FIELD_VERSION]
             self.compile_caps[TNS_CCAP_FIELD_VERSION] = self.ttc_field_version
-        if self.ttc_field_version < TNS_CCAP_FIELD_VERSION_23_4 \
-                and self.supports_end_of_response:
-            self.compile_caps[TNS_CCAP_TTC4] ^= TNS_CCAP_END_OF_RESPONSE
-            self.supports_end_of_response = False
 
     @cython.boundscheck(False)
     cdef void _adjust_for_server_runtime_caps(self, bytearray server_caps):

src/oracledb/impl/thin/protocol.pyx

@@ -287,6 +287,7 @@ cdef class Protocol(BaseProtocol):
             DataTypesMessage data_types_message
             FastAuthMessage fast_auth_message
             ProtocolMessage protocol_message
+            bint supports_end_of_response
             AuthMessage auth_message
 
         # if we can use OOB, send an urgent message now followed by a reset
@@ -311,10 +312,15 @@ cdef class Protocol(BaseProtocol):
             fast_auth_message.auth_message = auth_message
             self._process_message(fast_auth_message)
 
-        # otherwise, do the normal authentication
+        # otherwise, do the normal authentication; disable end of response for
+        # the first two messages as the server does not send an end of response
+        # for these messages
         else:
+            supports_end_of_response = self._caps.supports_end_of_response
+            self._caps.supports_end_of_response = False
             self._process_message(protocol_message)
             self._process_message(data_types_message)
+            self._caps.supports_end_of_response = supports_end_of_response
             self._process_message(auth_message)
 
         # send authorization message a second time, if needed, to respond to
@@ -637,6 +643,7 @@ cdef class BaseAsyncProtocol(BaseProtocol):
             DataTypesMessage data_types_message
             FastAuthMessage fast_auth_message
             ProtocolMessage protocol_message
+            bint supports_end_of_response
             AuthMessage auth_message
 
         # create the messages that need to be sent to the server
@@ -654,10 +661,15 @@ cdef class BaseAsyncProtocol(BaseProtocol):
             fast_auth_message.auth_message = auth_message
             await self._process_message(fast_auth_message)
 
-        # otherwise, do the normal authentication
+        # otherwise, do the normal authentication; disable end of response for
+        # the first two messages as the server does not send an end of response
+        # for these messages
         else:
+            supports_end_of_response = self._caps.supports_end_of_response
+            self._caps.supports_end_of_response = False
             await self._process_message(protocol_message)
             await self._process_message(data_types_message)
+            self._caps.supports_end_of_response = supports_end_of_response
             await self._process_message(auth_message)
 
         # send authorization message a second time, if needed, to respond to