Skip to content

Conversation

@wassimoo
Copy link
Contributor

  • Updated @ory/client-fetch, react, and react-dom to their latest versions.
  • Added a note about using the Ory Tunnel with the --dev flag for easier integration.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

a few small formatting etc nits to resolve then can be merged imo


This project demonstrates how to integrate Ory authentication into a React
application built with Vite and TypeScript.
This example demonstrates how to implement authentication in a React.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This example demonstrates how to implement authentication in a React.js
This example demonstrates how to implement authentication in a React

nit but I think the official name is React, also see https://react.dev/

- An Ory Network account with a project set up
- Your Ory Project ID

## Getting Started
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Getting Started
## Get started

please always use sentence casing and active form in headings - see README.md


## Getting Started

### 1. Install Dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 1. Install Dependencies
### 1. Install dependencies

```

# Start the development server
### 2. Start the Application
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 2. Start the Application
### 2. Start the application

used as the `baseUrl` in the Ory SDK configuration.
used as the `basePath` in the Ory SDK configuration.

## Making API Calls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Making API Calls
## Making API calls

The API server runs on port 8081 and requires the proper session cookies from
Ory to authenticate requests.

## Project Structure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Project Structure
## Project structure

- `src/AppWithApi.tsx` - Authentication with API integration example
- `src/api/index.js` - Express.js API server example

## Available Scripts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Available Scripts
## Available scripts


This guide shows how to create a simple React application and secure it with authentication powered by Ory. You can use this guide
with both Ory Network and self-hosted Ory software.
This guide shows how to create a simple React native application and secure it with authentication powered by Ory. You can use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This guide shows how to create a simple React native application and secure it with authentication powered by Ory. You can use
This guide shows how to create a simple React Native application and secure it with authentication powered by Ory. You can use

Comment on lines +67 to +68
`App.tsx` code below). The `--dev` flag disables security checks for easier integration and should not be used when running the
Tunnel in an insecure environment like public networks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`App.tsx` code below). The `--dev` flag disables security checks for easier integration and should not be used when running the
Tunnel in an insecure environment like public networks.
`App.tsx` code below). The `--dev` flag disables security checks for easier integration and shouldn't be used when running Ory Tunnel in an insecure environment like public networks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants