Merge pull request #840 from mcg-web/remove-deprecations

Remove deprecations

Author: mcg-web

UPGRADE.md

@@ -12,6 +12,8 @@ UPGRADE FROM 0.13 to 0.14
 - [Replace `overblog_graphql.global_variable` tag](#replace-overblog_graphqlglobal_variable-tag)
 - [Replace `resolver` expression function](#replace-resolver-expression-function)
 - [Rename `ResolverInterface` to `QueryInterface`](#rename-resolverinterface-to-queryinterface)
+- [Remove Argument deprecated method](#remove-argument-deprecated-method)
+- [Remove ConnectionBuilder deprecated class](#remove-connectionbuilder-deprecated-class)
 
 ### Customize the cursor encoder of the edges of a connection
 
@@ -199,6 +201,15 @@ Example:
 }
 ```
 
+### Remove Argument deprecated method
+
+Method `Overblog\GraphQLBundle\Definition\Argument::getRawArguments` is replaced by
+`Overblog\GraphQLBundle\Definition\Argument::getArrayCopy`.
+
+### Remove ConnectionBuilder deprecated class
+
+Class `Overblog\GraphQLBundle\Relay\Connection\Output\ConnectionBuilder` is replaced by
+`Overblog\GraphQLBundle\Relay\Connection\ConnectionBuilder`.
 
 UPGRADE FROM 0.12 to 0.13
 =======================

src/Definition/Argument.php

@@ -6,9 +6,6 @@
 
 use function array_key_exists;
 use function count;
-use function sprintf;
-use function trigger_error;
-use const E_USER_DEPRECATED;
 
 class Argument implements ArgumentInterface
 {
@@ -32,23 +29,6 @@ public function getArrayCopy(): array
         return $this->rawArguments;
     }
 
-    /**
-     * @deprecated This method is deprecated since 0.12 and will be removed in 0.13. You should use getArrayCopy method instead.
-     */
-    public function getRawArguments(): array
-    {
-        @trigger_error(
-            sprintf(
-                'This "%s" method is deprecated since 0.12 and will be removed in 0.13. You should use "%s::getArrayCopy" instead.',
-                __METHOD__,
-                __CLASS__
-            ),
-            E_USER_DEPRECATED
-        );
-
-        return $this->getArrayCopy();
-    }
-
     /**
      * @param int|string $offset
      */

src/Relay/Connection/Output/ConnectionBuilder.php

@@ -54,14 +54,4 @@ public function testGetRawArgs(): void
     {
         $this->assertSame($this->rawArgs, $this->argument->getArrayCopy());
     }
-
-    /**
-     * @group legacy
-     *
-     * @expectedDeprecation This "%s" method is deprecated since 0.12 and will be removed in 0.13. You should use "%s::getArrayCopy" instead.
-     */
-    public function testDeprecatedGetRawArgs(): void
-    {
-        $this->assertSame($this->rawArgs, $this->argument->getRawArguments());
-    }
 }

tests/Definition/ArgumentTest.php

@@ -11,7 +11,7 @@ Mutation:
                         defaultValue: 'foo'
             isStringNull:
                 type: Boolean!
-                resolve: "@=null === args.getRawArguments()['string']"
+                resolve: "@=null === args.getArrayCopy()['string']"
                 args:
                     string:
                         type: String
@@ -24,7 +24,7 @@ Mutation:
                         type: EchoInput!
             isStringNullUsingInput:
                 type: Boolean!
-                resolve: "@=null === args.getRawArguments()['input']['string']"
+                resolve: "@=null === args.getArrayCopy()['input']['string']"
                 args:
                     input:
                         type: isStringNullInput!