Simplify extending of fields definition

Author: a-melnikov

src/Config/Parser/GraphQL/ASTConverter/FieldsNode.php

@@ -4,6 +4,8 @@
 
 namespace Overblog\GraphQLBundle\Config\Parser\GraphQL\ASTConverter;
 
+use GraphQL\Language\AST\FieldDefinitionNode;
+use GraphQL\Language\AST\InputValueDefinitionNode;
 use GraphQL\Language\AST\Node;
 use GraphQL\Utils\AST;
 
@@ -17,7 +19,7 @@ public static function toConfig(Node $node, string $property = 'fields'): array
                 $fieldConfig = TypeNode::toConfig($definition) + DescriptionNode::toConfig($definition);
 
                 if (!empty($definition->arguments)) {
-                    $fieldConfig['args'] = self::toConfig($definition, 'arguments');
+                    $fieldConfig['args'] = static::toConfig($definition, 'arguments');
                 }
 
                 if (!empty($definition->defaultValue)) {
@@ -29,10 +31,21 @@ public static function toConfig(Node $node, string $property = 'fields'): array
                     $fieldConfig['deprecationReason'] = $directiveConfig['deprecationReason'];
                 }
 
-                $config[$definition->name->value] = $fieldConfig;
+                $config[$definition->name->value] = static::extendFieldConfig($fieldConfig, $definition);
             }
         }
 
         return $config;
     }
+
+    /**
+     * @param array<string,mixed> $fieldConfig
+     * @param FieldDefinitionNode|InputValueDefinitionNode $fieldDefinition
+     *
+     * @return array<string,mixed>
+     */
+    protected static function extendFieldConfig(array $fieldConfig, Node $fieldDefinition): array
+    {
+        return $fieldConfig;
+    }
 }

src/Config/Parser/GraphQL/ASTConverter/ObjectNode.php

@@ -32,9 +32,7 @@ public static function toConfig(Node $node): array
      */
     protected static function parseConfig(Node $node): array
     {
-        $config = DescriptionNode::toConfig($node) + [
-            'fields' => FieldsNode::toConfig($node),
-        ];
+        $config = DescriptionNode::toConfig($node) + static::parseFields($node);
 
         if (!empty($node->interfaces)) {
             $interfaces = [];
@@ -46,4 +44,14 @@ protected static function parseConfig(Node $node): array
 
         return $config;
     }
+
+    /**
+     * @return array{fields: array<string,mixed> }
+     */
+    protected static function parseFields(Node $node): array
+    {
+        return [
+            'fields' => FieldsNode::toConfig($node),
+        ];
+    }
 }

src/Config/TypeWithOutputFieldsDefinition.php

@@ -17,6 +17,7 @@ protected function outputFieldsSection(): NodeDefinition
 
         $node->isRequired()->requiresAtLeastOneElement();
 
+        /** @var ArrayNodeDefinition $prototype */
         $prototype = $node->useAttributeAsKey('name', false)->prototype('array');
 
         /** @phpstan-ignore-next-line */
@@ -84,6 +85,8 @@ protected function outputFieldsSection(): NodeDefinition
                 ->end()
             ->end();
 
+        $this->extendFieldPrototype($prototype);
+
         return $node;
     }
 
@@ -101,4 +104,9 @@ protected function fieldsBuilderSection(): ArrayNodeDefinition
 
         return $node;
     }
+
+    protected function extendFieldPrototype(ArrayNodeDefinition $prototype): void
+    {
+
+    }
 }